feat(spec-specs, tests): EIP-8037 halt refunds spilled state gas#2815
Merged
spencer-tb merged 4 commits intoMay 7, 2026
Merged
Conversation
2575201 to
3056f26
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devnets/bal/7 #2815 +/- ##
================================================
Coverage ? 85.58%
================================================
Files ? 630
Lines ? 39595
Branches ? 3935
================================================
Hits ? 33886
Misses ? 5084
Partials ? 625
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7 tasks
spencer-tb
added a commit
to spencer-tb/execution-specs
that referenced
this pull request
May 11, 2026
Add three blockchain tests that exercise top-level halt rollback in a contract-creation tx, complementing the existing successful-path coverage in test_inner_create_*. Each test constructs a different inner-frame outcome before the top-level INVALID and verifies that the created contract address is NONEXISTENT after the halt: - test_create_tx_halt_with_inner_create_revert_post_state: top runs INVALID after an inner CREATE frame REVERTs (the child performed a nested CREATE inside). - test_create_tx_halt_with_inner_create_success_post_state: top runs INVALID after a successful inner CREATE. - test_create_tx_halt_with_nested_create_fail_inside_create2_post_state: top runs INVALID after a successful CREATE2 whose initcode ran a failed nested CREATE. These pin the post-ethereum#2815 spec behaviour: a top-level exceptional halt drains state_gas_used, refunds the intrinsic NEW_ACCOUNT * cpsb, and rolls back every state change regardless of inner-frame outcomes. The scenario shapes are derived from benaadams' missing- test list in ethereum#2804.
spencer-tb
added a commit
to spencer-tb/execution-specs
that referenced
this pull request
May 11, 2026
Add three blockchain tests that exercise top-level halt rollback in a contract-creation tx, complementing the existing successful-path coverage in test_inner_create_*. Each test constructs a different inner-frame outcome before the top-level INVALID and verifies that the created contract address is NONEXISTENT after the halt: - test_create_tx_halt_with_inner_create_revert_post_state: top runs INVALID after an inner CREATE frame REVERTs (the child performed a nested CREATE inside). - test_create_tx_halt_with_inner_create_success_post_state: top runs INVALID after a successful inner CREATE. - test_create_tx_halt_with_nested_create_fail_inside_create2_post_state: top runs INVALID after a successful CREATE2 whose initcode ran a failed nested CREATE. These pin the post-ethereum#2815 spec behaviour: a top-level exceptional halt drains state_gas_used, refunds the intrinsic NEW_ACCOUNT * cpsb, and rolls back every state change regardless of inner-frame outcomes. The scenario shapes are derived from benaadams' missing- test list in ethereum#2804.
spencer-tb
added a commit
to spencer-tb/execution-specs
that referenced
this pull request
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Updates the EIP-8037 exceptional halt path with the updated EIP text. Top level halt now refunds the full state gas charge, including any portion that spilled into
gas_left, back to the reservoir, the same way revert does.✅ Checklist
just statictype(scope):.Cute Animal Picture