chore(test-client-clis): update GAS_USED_OVERFLOW exception mapper#2632
Merged
Merged
Conversation
ethrex no longer includes "Block gas used overflow" in its per-tx gas check error messages. Map GAS_USED_OVERFLOW to the same "Gas allowance exceeded" pattern used for GAS_ALLOWANCE_EXCEEDED, since ethrex uses a single per-tx check for both cases.
GAS_USED_OVERFLOW exception mapper
spencer-tb
approved these changes
Apr 7, 2026
spencer-tb
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Will wait for CI.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2632 +/- ##
================================================
Coverage 86.24% 86.24%
================================================
Files 599 599
Lines 36984 36984
Branches 3795 3795
================================================
Hits 31895 31895
Misses 4525 4525
Partials 564 564
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue Bot
pushed a commit
to lambdaclass/ethrex
that referenced
this pull request
Apr 10, 2026
…ing (#6447) Bump BAL fixtures from v5.5.1 to v5.6.1 across Makefile, CI workflows, docs, and fixture URL files. Fix two EIP-8037 correctness issues in `system.rs`: move the `is_static` check to CREATE/CREATE2 handlers (Amsterdam+ only) before stack pops and gas charging, matching ethereum/execution-specs#2608; move `increase_state_gas(STATE_GAS_NEW_ACCOUNT)` into `generic_create()` after `MAX_INIT_CODE_SIZE` validation so oversized CREATE doesn't burn state gas for an account never created. Fix per-tx gas check in `levm/mod.rs` to use `block_regular_gas_used` instead of `max(regular, state)` per ethereum/execution-specs#2583, and apply `min(TX_MAX_GAS_LIMIT, tx.gas)` cap per EIP-7825. Applied across `execute_block`, `execute_block_pipeline`, and `execute_block_parallel`. Update `payload.rs` to track `remaining_gas` using regular gas capacity only for Amsterdam. All 1103 BAL consume-engine tests pass. Along with ethereum/execution-specs#2632
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
ethrex no longer includes "Block gas used overflow" in its per-tx gas check error messages. Map
GAS_USED_OVERFLOWto the same "Gas allowance exceeded" pattern used forGAS_ALLOWANCE_EXCEEDED, since ethrex uses a single per-tx check for both cases.🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.