Skip to content

chore(tests): fix import sorting and stale type annotation for static checks#2612

Merged
spencer-tb merged 1 commit into
ethereum:eips/amsterdam/eip-8037from
spencer-tb:fix/eip8037-static-lint
Apr 1, 2026
Merged

chore(tests): fix import sorting and stale type annotation for static checks#2612
spencer-tb merged 1 commit into
ethereum:eips/amsterdam/eip-8037from
spencer-tb:fix/eip8037-static-lint

Conversation

@spencer-tb

@spencer-tb spencer-tb commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

🗒️ Description

Fix tox -e static failures on the eips/amsterdam/eip-8037 branch:

  • Auto-fix 137 ruff import sorting errors (I001) across ported static test files
  • Remove stale TransitionFork type annotation in tests/prague/eip7002_el_triggerable_withdrawals/conftest.py that caused a mypy error

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@spencer-tb spencer-tb added the C-chore Category: chore label Apr 1, 2026
@spencer-tb spencer-tb changed the title chore(lint): fix import sorting and stale type annotation for static checks chore(tests): fix import sorting and stale type annotation for static checks Apr 1, 2026
@spencer-tb spencer-tb added the A-tests Area: Consensus tests. label Apr 1, 2026
@spencer-tb spencer-tb merged commit 5e7832a into ethereum:eips/amsterdam/eip-8037 Apr 1, 2026
14 of 15 checks passed

@fselmo fselmo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

@codecov

codecov Bot commented Apr 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (eips/amsterdam/eip-8037@1a4ef23). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             eips/amsterdam/eip-8037    #2612   +/-   ##
==========================================================
  Coverage                           ?   88.17%           
==========================================================
  Files                              ?      524           
  Lines                              ?    31088           
  Branches                           ?     3036           
==========================================================
  Hits                               ?    27412           
  Misses                             ?     3161           
  Partials                           ?      515           
Flag Coverage Δ
unittests 88.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

spencer-tb added a commit to spencer-tb/execution-specs that referenced this pull request Apr 1, 2026
felix314159 pushed a commit to felix314159/execution-specs that referenced this pull request Apr 14, 2026
spencer-tb added a commit to spencer-tb/execution-specs that referenced this pull request Apr 21, 2026
spencer-tb added a commit to spencer-tb/execution-specs that referenced this pull request Apr 21, 2026
spencer-tb added a commit to spencer-tb/execution-specs that referenced this pull request May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tests Area: Consensus tests. C-chore Category: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants