feat(tests): EIP-8037 - code deposit halt must discard initcode state gas#2595
Merged
spencer-tb merged 2 commits intoApr 1, 2026
Conversation
3 tasks
qu0b
added a commit
to qu0b/execution-specs
that referenced
this pull request
Apr 1, 2026
…ses) Replace broken 2-tx test at 100M gas limit that didn't actually catch the divergence. Use the original single-tx test from ethereum#2595 with all 3 parametrized cases (oversized code x2, OOG deposit) at 60M gas limit which correctly exposes the bug. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
qu0b
added a commit
to qu0b/execution-specs
that referenced
this pull request
Apr 1, 2026
EELS patch: on top-level revert or exceptional halt, restore all execution state gas to the reservoir and reset state_gas_used to zero. Mirrors incorporate_child_on_error for child frames. Test from PR ethereum#2595: single-tx at 60M, 3 parametrized cases (oversized code x2, OOG deposit). Spec change: ethereum/EIPs#11476 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
qu0b
added a commit
to qu0b/execution-specs
that referenced
this pull request
Apr 1, 2026
EELS patch: on top-level revert or exceptional halt, restore all execution state gas to the reservoir and reset state_gas_used to zero. Mirrors incorporate_child_on_error for child frames. Test: 2-tx blockchain test at 100M where state gas is the binding dimension. TX1 deploys 14 KiB contract (high state gas). TX2 is a failing CREATE whose initcode state gas (GAS_NEW_ACCOUNT) is the observable delta in header.gas_used. This is the opposite of ethereum#2595 which tests that state gas IS counted at the top level (#11468). This test verifies state gas is NOT counted at the top level (#11476). Spec change: ethereum/EIPs#11476 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
qu0b
added a commit
to qu0b/execution-specs
that referenced
this pull request
Apr 1, 2026
EELS patch: on top-level revert or exceptional halt, restore all execution state gas to the reservoir and reset state_gas_used to zero. Mirrors incorporate_child_on_error for child frames. Test: 2-tx blockchain test at 100M where state gas is the binding dimension. TX1 deploys 14 KiB contract (high state gas). TX2 is a failing CREATE whose initcode state gas (GAS_NEW_ACCOUNT) is the observable delta in header.gas_used. This is the opposite of ethereum#2595 which tests that state gas IS counted at the top level (#11468). This test verifies state gas is NOT counted at the top level (#11476). Spec change: ethereum/EIPs#11476 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
qu0b
added a commit
to qu0b/execution-specs
that referenced
this pull request
Apr 1, 2026
EELS patch: on top-level revert or exceptional halt, restore all execution state gas to the reservoir and reset state_gas_used to zero. Mirrors incorporate_child_on_error for child frames. Test: 2-tx blockchain test at 100M where state gas is the binding dimension. TX1 deploys 14 KiB contract (high state gas). TX2 is a failing CREATE whose initcode state gas (GAS_NEW_ACCOUNT) is the observable delta in header.gas_used. This is the opposite of ethereum#2595 which tests that state gas IS counted at the top level (#11468). This test verifies state gas is NOT counted at the top level (#11476). Spec change: ethereum/EIPs#11476 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
spencer-tb
approved these changes
Apr 1, 2026
spencer-tb
left a comment
Contributor
There was a problem hiding this comment.
LGTM! @qu0b I just moved the test updated it to be more fork agnostic. PTAL
64f8162 to
9bf9dd0
Compare
Contributor
Author
|
@spencer-tb have you verified that it still fails against nethermind after your refactor? |
Contributor
Was just about to ping! Will check just now :) |
Contributor
Author
|
but looks good to me changes seem minor |
Contributor
|
Confirmed Nethermind still fails and Geth passes. |
Move test_code_deposit_halt_discards_initcode_state_gas from test_devnet3_repro.py into test_state_gas_create.py alongside other CREATE state gas tests. Replace hardcoded constants with fork methods (max_code_size), use nonexistent_account fixture, and expand coverage to all state_op x deposit_fail combinations (4 cases, up from 3).
9bf9dd0 to
4cc65c1
Compare
If EIP-8037 adopts the top-level state gas refund (ethereum/EIPs#11476), block gas accounting in these tests will need updating.
4cc65c1 to
2515b77
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-8037 #2595 +/- ##
==========================================================
Coverage ? 88.17%
==========================================================
Files ? 524
Lines ? 31088
Branches ? 3036
==========================================================
Hits ? 27412
Misses ? 3161
Partials ? 515
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2420c18
into
ethereum:eips/amsterdam/eip-8037
16 of 17 checks passed
spencer-tb
added a commit
to spencer-tb/execution-specs
that referenced
this pull request
Apr 1, 2026
… gas (ethereum#2595) Co-authored-by: spencer-tb <spencer.tb@ethereum.org>
marioevz
pushed a commit
that referenced
this pull request
Apr 9, 2026
… gas (#2595) Co-authored-by: spencer-tb <spencer.tb@ethereum.org>
marioevz
pushed a commit
that referenced
this pull request
Apr 10, 2026
… gas (#2595) Co-authored-by: spencer-tb <spencer.tb@ethereum.org>
felix314159
pushed a commit
to felix314159/execution-specs
that referenced
this pull request
Apr 14, 2026
… gas (ethereum#2595) Co-authored-by: spencer-tb <spencer.tb@ethereum.org>
felix314159
pushed a commit
that referenced
this pull request
Apr 16, 2026
… gas (#2595) Co-authored-by: spencer-tb <spencer.tb@ethereum.org>
spencer-tb
added a commit
that referenced
this pull request
Apr 17, 2026
… gas (#2595) Co-authored-by: spencer-tb <spencer.tb@ethereum.org>
qu0b
added a commit
to qu0b/execution-specs
that referenced
this pull request
Apr 17, 2026
EELS patch: on top-level revert or exceptional halt, restore all execution state gas to the reservoir and reset state_gas_used to zero. Mirrors incorporate_child_on_error for child frames. Test: 2-tx blockchain test at 100M where state gas is the binding dimension. TX1 deploys 14 KiB contract (high state gas). TX2 is a failing CREATE whose initcode state gas (GAS_NEW_ACCOUNT) is the observable delta in header.gas_used. This is the opposite of ethereum#2595 which tests that state gas IS counted at the top level (#11468). This test verifies state gas is NOT counted at the top level (#11476). Spec change: ethereum/EIPs#11476 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
qu0b
added a commit
to qu0b/execution-specs
that referenced
this pull request
Apr 17, 2026
EELS patch: on top-level revert or exceptional halt, restore all execution state gas to the reservoir and reset state_gas_used to zero. Mirrors incorporate_child_on_error for child frames. Test: 2-tx blockchain test at 100M where state gas is the binding dimension. TX1 deploys 14 KiB contract (high state gas). TX2 is a failing CREATE whose initcode state gas (GAS_NEW_ACCOUNT) is the observable delta in header.gas_used. This is the opposite of ethereum#2595 which tests that state gas IS counted at the top level (#11468). This test verifies state gas is NOT counted at the top level (#11476). Spec change: ethereum/EIPs#11476 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
marioevz
pushed a commit
that referenced
this pull request
Apr 20, 2026
… gas (#2595) Co-authored-by: spencer-tb <spencer.tb@ethereum.org>
spencer-tb
added a commit
that referenced
this pull request
Apr 20, 2026
… gas (#2595) Co-authored-by: spencer-tb <spencer.tb@ethereum.org>
spencer-tb
added a commit
to spencer-tb/execution-specs
that referenced
this pull request
Apr 21, 2026
… gas (ethereum#2595) Co-authored-by: spencer-tb <spencer.tb@ethereum.org>
spencer-tb
added a commit
to spencer-tb/execution-specs
that referenced
this pull request
Apr 21, 2026
… gas (ethereum#2595) Co-authored-by: spencer-tb <spencer.tb@ethereum.org>
spencer-tb
added a commit
that referenced
this pull request
Apr 21, 2026
… gas (#2595) Co-authored-by: spencer-tb <spencer.tb@ethereum.org>
fselmo
pushed a commit
that referenced
this pull request
May 5, 2026
… gas (#2595) Co-authored-by: spencer-tb <spencer.tb@ethereum.org>
spencer-tb
added a commit
to spencer-tb/execution-specs
that referenced
this pull request
May 22, 2026
… gas (ethereum#2595) Co-authored-by: spencer-tb <spencer.tb@ethereum.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Summary
Root cause
When CREATE initcode performs a state-creating operation (CALL to new account or inner CREATE, charging
GAS_NEW_ACCOUNT = 112 * cpsb) and then the code deposit fails (code too large or OOG), the exceptional halt reverts all state changes. TheGAS_NEW_ACCOUNTstate gas for the reverted operation must NOT count inblock_state_gas_used.A client that retains the reverted state gas in the block accumulator will compute
block_gas_used = max(block_regular_gas, block_state_gas)incorrectly — the inflatedblock_state_gasproduces a different headergasUsed.Motivation
BAL devnet-3 chain split at block 17: nethermind's block header
gasUsedwas exactly 131,488 (=GAS_NEW_ACCOUNT) lower than the EELS reference. Traced via EVM step comparison toRevertRefundToHaltnot properly discarding the child frame'sStateGasUsedaccumulated during initcode execution.🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.