Skip to content

src(fix): framework bug fix for slotnum#2108

Merged
spencer-tb merged 1 commit into
ethereum:eips/amsterdam/eip-7843from
felix314159:eip7843
Jan 30, 2026
Merged

src(fix): framework bug fix for slotnum#2108
spencer-tb merged 1 commit into
ethereum:eips/amsterdam/eip-7843from
felix314159:eip7843

Conversation

@felix314159

@felix314159 felix314159 commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

🗒️ Description

With this patch on our side and this patch on geth's side I was able to successfully run all 7843 tests against geth. also almost all 8024 tests pass (179 out of 184)

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks: 
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

spencer-tb
spencer-tb approved these changes Jan 30, 2026
View reviewed changes

@spencer-tb spencer-tb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov

codecov Bot commented Jan 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (eips/amsterdam/eip-7843@b63306f). Learn more about missing BASE report.

Additional details and impacted files 
@@                    Coverage Diff                     @@
##             eips/amsterdam/eip-7843    #2108   +/-   ##
==========================================================
  Coverage                           ?   86.07%           
==========================================================
  Files                              ?      599           
  Lines                              ?    39483           
  Branches                           ?     3781           
==========================================================
  Hits                               ?    33986           
  Misses                             ?     4864           
  Partials                           ?      633
Flag Coverage Δ
unittests 86.07% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spencer-tb spencer-tb merged commit 4823f1a into ethereum:eips/amsterdam/eip-7843 Jan 30, 2026
18 checks passed
fselmo pushed a commit that referenced this pull request Feb 12, 2026
@felix314159 @fselmo
src(fix): framework bug fix for slotnum (#2108)
b1b14a2
gurukamath pushed a commit that referenced this pull request Feb 24, 2026
@felix314159 @gurukamath
src(fix): framework bug fix for slotnum (#2108)
dba41c0
marioevz pushed a commit that referenced this pull request Feb 27, 2026
@felix314159
src(fix): framework bug fix for slotnum (#2108)
cfdbfae
spencer-tb pushed a commit to spencer-tb/execution-specs that referenced this pull request Mar 3, 2026
@felix314159 @spencer-tb
src(fix): framework bug fix for slotnum (ethereum#2108)
3351c40
spencer-tb pushed a commit to spencer-tb/execution-specs that referenced this pull request Mar 6, 2026
@felix314159 @spencer-tb
src(fix): framework bug fix for slotnum (ethereum#2108)
e30486f
spencer-tb pushed a commit to spencer-tb/execution-specs that referenced this pull request Mar 10, 2026
@felix314159 @spencer-tb
src(fix): framework bug fix for slotnum (ethereum#2108)
5483b1c
fselmo pushed a commit to fselmo/execution-specs that referenced this pull request Mar 10, 2026
@felix314159 @fselmo
src(fix): framework bug fix for slotnum (ethereum#2108)
59db868
fselmo pushed a commit to fselmo/execution-specs that referenced this pull request Mar 10, 2026
@felix314159 @fselmo
src(fix): framework bug fix for slotnum (ethereum#2108)
ff89924
fselmo pushed a commit to fselmo/execution-specs that referenced this pull request Mar 13, 2026
@felix314159 @fselmo
src(fix): framework bug fix for slotnum (ethereum#2108)
61bc1d5
fselmo pushed a commit to fselmo/execution-specs that referenced this pull request Mar 17, 2026
@felix314159 @fselmo
src(fix): framework bug fix for slotnum (ethereum#2108)
988a7a0
fselmo pushed a commit to fselmo/execution-specs that referenced this pull request Mar 18, 2026
@felix314159 @fselmo
src(fix): framework bug fix for slotnum (ethereum#2108)
6e8d71e
marioevz pushed a commit that referenced this pull request Mar 24, 2026
@felix314159 @marioevz
src(fix): framework bug fix for slotnum (#2108)
1075136
marioevz pushed a commit that referenced this pull request Apr 8, 2026
@felix314159 @marioevz
src(fix): framework bug fix for slotnum (#2108)
a9cfea7
github-actions Bot pushed a commit that referenced this pull request Apr 10, 2026
@felix314159 @github-actions
src(fix): framework bug fix for slotnum (#2108)
bd0aa4e
spencer-tb pushed a commit to spencer-tb/execution-specs that referenced this pull request Apr 20, 2026
@felix314159 @spencer-tb
src(fix): framework bug fix for slotnum (ethereum#2108)
a92ef6d
LouisTsai-Csie pushed a commit that referenced this pull request Apr 27, 2026
@felix314159 @LouisTsai-Csie
src(fix): framework bug fix for slotnum (#2108)
9a93703
marioevz added a commit that referenced this pull request May 14, 2026
@kclowes @felix314159
@fselmo @marioevz @spencer-tb
feat(spec-specs, spec-tests): add EIP-7843 SLOTNUM opcode (#2853)
b3f5df5 
* feat(src): Initial EIP-7843 (SLOTNUM) Implementation (#2007)

* feat(amsterdam): Implement EIP-7843 SLOTNUM opcode

* mario feedback

* fix(tests): minor fixes and updates for eip7843 (#2057)

* fix(tests): minor updates to eip-7843 following #2007

* fix: account for slotnum in genesis creation

* fix: append slot_number in fixture_loader.py

* execution-api 7843 pr 731 implemented (#2101)

* src(fix): framework bug fix for slotnum (#2108)

* refactor(tests): Condition EIP-7843 tests to EIP inclusion

* fix(specs): align EIP-7843 SLOTNUM gas references with renamed constants

Replace stale GAS_BASE reference with GasCosts.OPCODE_SLOTNUM (= BASE)
to match the opcode gas naming convention used across block
instructions on forks/amsterdam. Also update the test-fork mixin to use
gas_costs.BASE instead of the retired gas_costs.GAS_BASE.

* Remove stray header_bal_hash_required checks

* Remove unneeded eip7843 spec.py

---------

Co-authored-by: felix <felix314159@users.noreply.github.com>
Co-authored-by: felipe <fselmo2@gmail.com>
Co-authored-by: marioevz <marioevz@gmail.com>
Co-authored-by: spencer-tb <spencer.tb@ethereum.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spencer-tb spencer-tb spencer-tb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@felix314159 @spencer-tb