fix(tests): fix legacy tests to run with eip-7778 by gurukamath · Pull Request #2048 · ethereum/execution-specs

gurukamath · 2026-01-20T14:04:05Z

🗒️ Description

Fix legacy tests to run with EIP-7778

🔗 Related Issues or PRs

#1401

✅ Checklist

All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
```
uvx tox -e static
```
All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.

Cute Animal Picture

codecov · 2026-01-20T17:08:03Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (e958b62) to head (ee6f68d).
⚠️ Report is 85 commits behind head on eips/amsterdam/eip-7778.

Additional details and impacted files

@@                     Coverage Diff                     @@
##           eips/amsterdam/eip-7778    #2048      +/-   ##
===========================================================
- Coverage                    86.33%   86.07%   -0.27%     
===========================================================
  Files                          538      599      +61     
  Lines                        34557    39530    +4973     
  Branches                      3222     3780     +558     
===========================================================
+ Hits                         29835    34024    +4189     
- Misses                        4148     4872     +724     
- Partials                       574      634      +60

Flag	Coverage Δ
unittests	`86.07% <ø> (-0.27%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

fselmo

lgtm! Just left a single comment as a suggestion 👍🏼

fselmo · 2026-01-20T19:47:48Z

This just needed a rebase with some big changes that came in through forks/amsterdam -> eips/amsterdam/eip-7778. I rebased here, should be gtg.

marioevz

LGTM, nothing to add other than I second Felipe's comment. Thanks!

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

@gurukamath

…ut refunds (#2840) * feat(spec-specs): Implement EIP-7778 Block Gas Accounting without Refunds (#1401) * feat(specs): add eip-7778 implementation * fix(specs) spliting receipt gas from block gas * revert receipt_gas_used * make sure that the calldata floor cost overwrites the tx gas before refund * receipt gas used after refunds * clarify variable naming @gurukamath * revert to using gas used after refunds for cumulative gas in receipt and add gasSpent to receipt * spec(amsterdam): fix code formatting --------- Co-authored-by: Guruprasad Kamath <guru241987@gmail.com> * fix(tests): fix legacy tests to run with eip-7778 (#2048) * fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam * feat(spec-tests): add basic eip7778 test (#2045) * feat(spec-tests): add eip-7778 tests for calldata checks (#2060) * feat(spec-tests): add eip-7778 for calldata checks * feat(spec-tests): post review - use code gas_cost function Co-authored-by: Louis Tsai <72684086+LouisTsai-Csie@users.noreply.github.com> * Apply suggestions from code review --------- Co-authored-by: Louis Tsai <72684086+LouisTsai-Csie@users.noreply.github.com> Co-authored-by: Mario Vega <marioevz@gmail.com> * fix(tests): Fix gas used/spent in EIP-7702 tests (#2068) * feat(spec-specs): use post refund gas in receipts in EIP-7778 (#2073) * fix(test): Update refspec for EIP-7778 to match latest revision (#2093) * feat(test-forks): Add EIP-7778 * refactor(tests): Condition EIP-7778 tests to EIP inclusion * fix(test): use deterministic iteration order for refund types The set iteration in `build_refund_tx` is non-deterministic due to Python's hash randomization, causing fixture output to vary between runs. Sort by enum value to ensure reproducible fixtures. * doc: remove changelog md * fix: broken auth tx benchmark * doc: add eip checklist * fix: typo * Update tests/benchmark/compute/scenario/test_transaction_types.py * Apply suggestions from code review Co-authored-by: Mario Vega <marioevz@gmail.com> --------- Co-authored-by: Toni Wahrstätter <51536394+nerolation@users.noreply.github.com> Co-authored-by: Guruprasad Kamath <guru241987@gmail.com> Co-authored-by: Guruprasad Kamath <48196632+gurukamath@users.noreply.github.com> Co-authored-by: Mario Vega <marioevz@gmail.com> Co-authored-by: felipe <fselmo2@gmail.com> Co-authored-by: spencer-tb <spencer.tb@ethereum.org>

gurukamath requested a review from LouisTsai-Csie January 20, 2026 14:04

danceratopz added this to the bal devnet-2 milestone Jan 20, 2026

fselmo self-requested a review January 20, 2026 15:55

fselmo approved these changes Jan 20, 2026

View reviewed changes

Comment thread tests/prague/eip7623_increase_calldata_cost/test_refunds.py

fselmo force-pushed the eips/amsterdam/eip-7778 branch from 52258b0 to e9b90ca Compare January 20, 2026 18:05

fselmo force-pushed the fix-legacy-tests-7778 branch from 3c64f97 to 620da14 Compare January 20, 2026 19:13

fselmo force-pushed the eips/amsterdam/eip-7778 branch from e9b90ca to 017cca2 Compare January 20, 2026 19:43

fix(tests): fix legacy tests to run with eip-7778

725df98

fselmo force-pushed the fix-legacy-tests-7778 branch from 620da14 to 725df98 Compare January 20, 2026 19:45

marioevz approved these changes Jan 20, 2026

View reviewed changes

fix(tests): check gas_spent and gas_used after Amsterdam

ee6f68d

gurukamath merged commit d369475 into ethereum:eips/amsterdam/eip-7778 Jan 21, 2026
15 of 18 checks passed

gurukamath added a commit that referenced this pull request Jan 22, 2026

fix(tests): fix legacy tests to run with eip-7778 (#2048)

ed205ae

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

github-actions Bot pushed a commit that referenced this pull request Jan 22, 2026

fix(tests): fix legacy tests to run with eip-7778 (#2048)

0b345d5

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

fselmo pushed a commit that referenced this pull request Jan 23, 2026

fix(tests): fix legacy tests to run with eip-7778 (#2048)

ca1b03a

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

github-actions Bot pushed a commit that referenced this pull request Jan 23, 2026

fix(tests): fix legacy tests to run with eip-7778 (#2048)

c6cc57f

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

github-actions Bot pushed a commit that referenced this pull request Jan 26, 2026

fix(tests): fix legacy tests to run with eip-7778 (#2048)

c7327e5

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

marioevz pushed a commit that referenced this pull request Jan 29, 2026

fix(tests): fix legacy tests to run with eip-7778 (#2048)

1c12890

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

fselmo pushed a commit that referenced this pull request Feb 3, 2026

fix(tests): fix legacy tests to run with eip-7778 (#2048)

068e410

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

spencer-tb pushed a commit that referenced this pull request Feb 11, 2026

fix(tests): fix legacy tests to run with eip-7778 (#2048)

29b8329

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

fselmo pushed a commit to fselmo/execution-specs that referenced this pull request Feb 12, 2026

fix(tests): fix legacy tests to run with eip-7778 (ethereum#2048)

d45f0a0

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

fselmo pushed a commit that referenced this pull request Feb 12, 2026

fix(tests): fix legacy tests to run with eip-7778 (#2048)

e153804

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

fselmo pushed a commit that referenced this pull request Feb 13, 2026

fix(tests): fix legacy tests to run with eip-7778 (#2048)

25835a9

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

gurukamath added a commit that referenced this pull request Feb 24, 2026

fix(tests): fix legacy tests to run with eip-7778 (#2048)

6ad448b

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

gurukamath added a commit that referenced this pull request Feb 25, 2026

fix(tests): fix legacy tests to run with eip-7778 (#2048)

697ef0e

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

github-actions Bot pushed a commit that referenced this pull request Feb 27, 2026

fix(tests): fix legacy tests to run with eip-7778 (#2048)

adb02a1

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

spencer-tb pushed a commit to spencer-tb/execution-specs that referenced this pull request Mar 3, 2026

fix(tests): fix legacy tests to run with eip-7778 (ethereum#2048)

b9f3965

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

spencer-tb pushed a commit to spencer-tb/execution-specs that referenced this pull request Mar 6, 2026

fix(tests): fix legacy tests to run with eip-7778 (ethereum#2048)

0f0f70c

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

spencer-tb pushed a commit to spencer-tb/execution-specs that referenced this pull request Mar 10, 2026

fix(tests): fix legacy tests to run with eip-7778 (ethereum#2048)

130c228

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

fselmo pushed a commit to fselmo/execution-specs that referenced this pull request Mar 10, 2026

fix(tests): fix legacy tests to run with eip-7778 (ethereum#2048)

d25afad

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

fselmo pushed a commit to fselmo/execution-specs that referenced this pull request Mar 10, 2026

fix(tests): fix legacy tests to run with eip-7778 (ethereum#2048)

40d28b9

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

fselmo pushed a commit to fselmo/execution-specs that referenced this pull request Mar 13, 2026

fix(tests): fix legacy tests to run with eip-7778 (ethereum#2048)

ec73a44

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

fselmo pushed a commit to fselmo/execution-specs that referenced this pull request Mar 17, 2026

fix(tests): fix legacy tests to run with eip-7778 (ethereum#2048)

806fb84

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

fselmo pushed a commit to fselmo/execution-specs that referenced this pull request Mar 18, 2026

fix(tests): fix legacy tests to run with eip-7778 (ethereum#2048)

b17e48b

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

marioevz pushed a commit that referenced this pull request Mar 24, 2026

fix(tests): fix legacy tests to run with eip-7778 (#2048)

70b99be

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

marioevz pushed a commit that referenced this pull request Apr 8, 2026

fix(tests): fix legacy tests to run with eip-7778 (#2048)

59d9ca5

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

github-actions Bot pushed a commit that referenced this pull request Apr 10, 2026

fix(tests): fix legacy tests to run with eip-7778 (#2048)

74b010f

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

spencer-tb pushed a commit to spencer-tb/execution-specs that referenced this pull request Apr 20, 2026

fix(tests): fix legacy tests to run with eip-7778 (ethereum#2048)

b79fc9f

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

LouisTsai-Csie pushed a commit that referenced this pull request May 13, 2026

fix(tests): fix legacy tests to run with eip-7778 (#2048)

9d8334e

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(tests): fix legacy tests to run with eip-7778#2048

fix(tests): fix legacy tests to run with eip-7778#2048
gurukamath merged 2 commits into
ethereum:eips/amsterdam/eip-7778from
gurukamath:fix-legacy-tests-7778

gurukamath commented Jan 20, 2026

Uh oh!

codecov Bot commented Jan 20, 2026 •

edited

Loading

Uh oh!

fselmo left a comment •

edited

Loading

Uh oh!

Uh oh!

fselmo commented Jan 20, 2026

Uh oh!

marioevz left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

gurukamath commented Jan 20, 2026

🗒️ Description

🔗 Related Issues or PRs

✅ Checklist

Cute Animal Picture

Uh oh!

codecov Bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

fselmo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fselmo commented Jan 20, 2026

Uh oh!

marioevz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Jan 20, 2026 •

edited

Loading

fselmo left a comment •

edited

Loading