🗒️ Description

This PR addresses issues when generating pre-allocation groups with the BenchmarkTest spec type.

There were two main issues that had to be addressed for this:

BenchmarkTest.get_genesis_environment not using BlockchainTest.get_genesis_environment

BenchmarkTest.get_genesis_environment was directly generating the genesis from env without adding the extra required argument that BlockchainTest.get_genesis_environment uses.

One potential proper (follow-up) fix could be that BenchmarkTest inherits BlockchainTest.

BenchmarkTest.generate modifying pre

BenchmarkTest modified an invariant that the pre-alloc grouping relied on: pre is not touched after the test function completes.

This resulted in, correctly, test filling failing on the test running step because the base Alloc does not implement deploy_contract because there should not be any more deployments.

But the problem was that BenchmarkTest required the fork instance in order to determine how many blocks to use (because of the transaction gas limit cap), and this value was only passed when the generate or the execution functions are called.

Solution was to include fork in the BaseTest class and make it mandatory for the filler, execute, or any other code that instantiated a test spec, to pass the fork during the initialization:
https://github.com/marioevz/execution-specs/blob/fc2bd475b8e7caf506b39ec6453e9d049e8f418e/packages/testing/src/execution_testing/cli/pytest_commands/plugins/filler/filler.py#L1353
Example in an unit test:
https://github.com/marioevz/execution-specs/blob/fc2bd475b8e7caf506b39ec6453e9d049e8f418e/packages/testing/src/execution_testing/cli/pytest_commands/plugins/filler/tests/test_prealloc_group.py#L56

This resulted in fork being removed from generate, execute and other instance methods within BaseTest, which is a nice bonus.

🔗 Related Issues or PRs

N/A.

✅ Checklist

• All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:

  uvx tox -e static

• All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
• All: Considered adding an entry to CHANGELOG.md.
• All: Considered updating the online docs in the ./docs/ directory.
• All: Set appropriate labels for the changes (only maintainers can apply labels).
• Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
• Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
• Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture