Skip to content

chore(execute): fix execute hive mode#1698

Closed
spencer-tb wants to merge 1 commit into
ethereum:forks/osakafrom
spencer-tb:fix/execute-hive
Closed

chore(execute): fix execute hive mode#1698
spencer-tb wants to merge 1 commit into
ethereum:forks/osakafrom
spencer-tb:fix/execute-hive

Conversation

@spencer-tb

@spencer-tb spencer-tb commented Oct 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

🗒️ Description

Fixes execute hive mode, specifically for adding the execute-blobs simulator to the hive CI.

🔗 Related Issues or PRs

Blocker for: ethpandaops/fusaka-devnets#115
Requires: ethereum/hive#1365

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks: 
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@spencer-tb spencer-tb mentioned this pull request Oct 27, 2025
Closed
marioevz
marioevz reviewed Oct 27, 2025
View reviewed changes
Comment thread ...s/testing/src/execution_testing/cli/pytest_commands/pytest_ini_files/pytest-execute-hive.ini Outdated
minversion = 7.0
python_files = *.py
testpaths = tests/
testpaths = ../../tests/

@marioevz marioevz Oct 27, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right, if the cwd is ./execution-specs/ I think it should not do relative paths.

What's the error you are seeing that you are trying to fix with this?

@spencer-tb spencer-tb Oct 28, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed thanks!

@spencer-tb spencer-tb marked this pull request as draft October 27, 2025 17:23
@codecov-commenter

codecov-commenter commented Oct 27, 2025

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (c3e5260) to head (ddbef39).
⚠️ Report is 2 commits behind head on forks/osaka.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##           forks/osaka    #1698   +/-   ##
============================================
  Coverage        86.07%   86.07%           
============================================
  Files              743      743           
  Lines            44078    44078           
  Branches          3894     3894           
============================================
  Hits             37938    37938           
  Misses            5659     5659           
  Partials           481      481
Flag Coverage Δ
unittests 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spencer-tb spencer-tb marked this pull request as ready for review October 28, 2025 13:52
@spencer-tb spencer-tb mentioned this pull request Oct 29, 2025
Merged
8 tasks
danceratopz
danceratopz reviewed Oct 29, 2025
View reviewed changes

@danceratopz danceratopz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @spencer-tb! Can you check whether adding the test_case_description fixture is really necessary?

Comment thread packages/testing/src/execution_testing/cli/pytest_commands/plugins/execute/rpc/hive.py
Comment on lines +238 to +241
@pytest.fixture(scope="function")
def test_case_description(request: pytest.FixtureRequest) -> str:
"""The description of the current test case for hive."""
return f"Test: {request.node.name}"

@danceratopz danceratopz Oct 29, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will return the test ID, not the test case description as expected by Hive. Is this necessary? Perhaps you're intentionally overwriting this fixture?

execution-specs/packages/testing/src/execution_testing/cli/pytest_commands/plugins/shared/execute_fill.py

Lines 183 to 205 in 15b5cfd

@pytest.fixture(scope="function")
def test_case_description(request: pytest.FixtureRequest) -> str:
"""
Fixture to extract and combine docstrings from the test class and the test
function.
"""
description_unavailable = "No description available - add a docstring to the python test class or function."
test_class_doc = ""
test_function_doc = ""
if hasattr(request.node, "cls"):
test_class_doc = (
f"Test class documentation:\n{request.cls.__doc__}"
if request.cls
else ""
)
if hasattr(request.node, "function"):
test_function_doc = (
f"{request.function.__doc__}" if request.function.__doc__ else ""
)
if not test_class_doc and not test_function_doc:
return description_unavailable
combined_docstring = f"{test_class_doc}\n\n{test_function_doc}".strip()
return combined_docstring

@spencer-tb spencer-tb closed this Nov 13, 2025
SamWilsn pushed a commit that referenced this pull request Dec 9, 2025
@jsign @jochem-brouwer
zkevm: add 0-param opcodes coverage (#1698)
4b3cbde 
* zkevm: add generic zero-param opcodes

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* zkevm: add CALLVALUE coverage

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* add comment

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* zkevm: add RETURNDATASIZE coverage

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* zkevm: add MSIZE coverage & fixes

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* fixes

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* change params

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* Update tests/zkevm/test_worst_compute.py

Co-authored-by: Jochem Brouwer <jochembrouwer96@gmail.com>

* feedback

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* add comment

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* generalize returndata test

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* fix

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* Update tests/zkevm/test_worst_compute.py

Co-authored-by: Jochem Brouwer <jochembrouwer96@gmail.com>

* separate RETURNDATASIZE tests

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* nit

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

---------

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Co-authored-by: Jochem Brouwer <jochembrouwer96@gmail.com>
@danceratopz danceratopz added A-test-cli Area: execution_testing.cli and removed A-test-commands labels Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marioevz marioevz marioevz left review comments

@danceratopz danceratopz danceratopz left review comments

Assignees

No one assigned

Labels

A-test-cli Area: execution_testing.cli C-chore Category: chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spencer-tb @codecov-commenter @marioevz @danceratopz