Skip to content

feat(tests): Add missing OOG tests: EXP, LOG and constant gas generally#1686

Merged
marioevz merged 9 commits into
ethereum:forks/osakafrom
pdobacz:tests/oog
Nov 27, 2025
Merged

feat(tests): Add missing OOG tests: EXP, LOG and constant gas generally#1686
marioevz merged 9 commits into
ethereum:forks/osakafrom
pdobacz:tests/oog

Conversation

@pdobacz

@pdobacz pdobacz commented Oct 27, 2025

Copy link
Copy Markdown
Contributor

🗒️ Description

Adds some missing cases to cover situations where either gas is not enough to cover constant (static) cost or specific dynamic costs of EXP and LOG opcodes

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@pdobacz pdobacz force-pushed the tests/oog branch 2 times, most recently from 312792d to c1f4e24 Compare October 27, 2025 10:44
Anuoluwapo25 pushed a commit to Anuoluwapo25/execution-specs that referenced this pull request Oct 27, 2025
* refactor(forks): Pydantic-friendly `Fork` type

* fix(tests): Bad import

* docs(forks): remove `blockchain_test_network_name` from docs

---------

Co-authored-by: danceratopz <danceratopz@gmail.com>
@LouisTsai-Csie LouisTsai-Csie self-requested a review October 29, 2025 10:51
@codecov-commenter

codecov-commenter commented Nov 5, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.08%. Comparing base (fa1a2bb) to head (8a7564c).
⚠️ Report is 16 commits behind head on forks/osaka.

Additional details and impacted files
@@               Coverage Diff               @@
##           forks/osaka    #1686      +/-   ##
===============================================
- Coverage        86.08%   86.08%   -0.01%     
===============================================
  Files              743      743              
  Lines            44072    44076       +4     
  Branches          3891     3891              
===============================================
+ Hits             37938    37941       +3     
- Misses            5656     5657       +1     
  Partials           478      478              
Flag Coverage Δ
unittests 86.08% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marioevz marioevz requested review from marioevz and removed request for LouisTsai-Csie November 26, 2025 13:15

@marioevz marioevz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, I pushed some commits to make the tests more future proof.

@marioevz marioevz merged commit f23e4ab into ethereum:forks/osaka Nov 27, 2025
12 checks passed
@pdobacz pdobacz deleted the tests/oog branch November 28, 2025 17:05
SamWilsn pushed a commit that referenced this pull request Dec 9, 2025
* refactor(forks): Pydantic-friendly `Fork` type

* fix(tests): Bad import

* docs(forks): remove `blockchain_test_network_name` from docs

---------

Co-authored-by: danceratopz <danceratopz@gmail.com>
SamWilsn pushed a commit that referenced this pull request Dec 9, 2025
* refactor(forks): Pydantic-friendly `Fork` type

* fix(tests): Bad import

* docs(forks): remove `blockchain_test_network_name` from docs

---------

Co-authored-by: danceratopz <danceratopz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants