Skip to content

chore: remove unnecessary flag from tox commands#1668

Merged
fselmo merged 1 commit into
ethereum:forks/osakafrom
fselmo:chore/remove-unnecessary-flag-from-docs-commands
Oct 23, 2025
Merged

chore: remove unnecessary flag from tox commands#1668
fselmo merged 1 commit into
ethereum:forks/osakafrom
fselmo:chore/remove-unnecessary-flag-from-docs-commands

Conversation

@fselmo

@fselmo fselmo commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

🗒️ Description

With #1657, we no longer need to specify the flag --with=tox-uv for tox commands as the default runner uses tox with tox-uv.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

Screenshot 2025-10-23 at 13 04 18

With ethereum#1657, we no longer need to specify the flag
``--with=tox-uv`` for ``tox`` commands as the default runner uses ``tox``
with ``tox-uv``.
@fselmo fselmo added A-doc Area: documentation C-chore Category: chore labels Oct 23, 2025

@SamWilsn SamWilsn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we ever need this? My local tox would always go fetch tox-uv itself before running.

@fselmo

fselmo commented Oct 23, 2025

Copy link
Copy Markdown
Contributor Author

Did we ever need this? My local tox would always go fetch tox-uv itself before running.

At some point we did... not sure when we started inherently using tox-uv then... perhaps this was only in our EEST configuration in the past 🤷🏼

@fselmo fselmo merged commit a328883 into ethereum:forks/osaka Oct 23, 2025
9 of 10 checks passed
@fselmo fselmo deleted the chore/remove-unnecessary-flag-from-docs-commands branch October 23, 2025 19:18
chetna-mittal pushed a commit to gnosischain/execution-specs that referenced this pull request Oct 24, 2025
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-doc Area: documentation C-chore Category: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants