fix(docs): Add workflows and tox envs for building docs#1659
Conversation
marioevz
left a comment
There was a problem hiding this comment.
Gave this a quick look and left some comments, thanks!
41cc805 to
1f58577
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1659 +/- ##
===============================================
+ Coverage 86.07% 86.08% +0.01%
===============================================
Files 743 743
Lines 44078 44072 -6
Branches 3894 3891 -3
===============================================
Hits 37938 37938
+ Misses 5659 5656 -3
+ Partials 481 478 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
After #1654 is merged, will need to find-replace |
spencer-tb
left a comment
There was a problem hiding this comment.
Thanks! Some smol comments. Can re-evaluate once the weld has progressed.
Maybe we should change eest to ethereum-testing or testing @danceratopz
ethereum#1659) Add a worst-case test running a block with many `ADDMOD` or `MULMOD` instructions with arguments of the parametrized range.
c77fdd3 to
896fe96
Compare
5752b8a to
b44fa53
Compare
c9881cd to
ea111a2
Compare
|
It was all working, then I rebased onto the latest forks/osaka and it broke again 🤦♀️ |
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
22f3724 to
fba4bf7
Compare
|
@SamWilsn thanks for all of your review comments! I addressed them today and cleaned up a little. This would be good to from my side. |
danceratopz
left a comment
There was a problem hiding this comment.
pypy3 and json_infra failed due to 503 service unavailable for the ethquoakaops ubuntu package server (which has now resolved). Re-ran pypy3, will not re-run json_infra.
🗒️ Description
WELDs the documentation infrastructure from EEST into the project including automated workflows, tox environments, and tooling to maintain documentation quality.
Key Changes
GitHub Workflows:
.github/workflows/test-docs.yamlworkflow to automatically build and validate EEST documentation on push and pull request eventspackages/tests/**,tests/**, and the workflow file itselfTox Environments:
changelog: Validates changelog entriesmkdocs: Builds HTML documentation using mkdocs with strict mode enabledmarkdownlint: Lints markdown files using markdownlintspec-docs: Generate documentation for the specification code using doccDocumentation Tooling:
src/ethereum_spec_tools/whitelist.py: Python script to manage the codespell whitelist with proper alphabetical sorting and formatting.markdownlint.yaml: Configuration for markdownlint with appropriate rule customizationswhitelist.txt: Consolidated EEST's whitelist into ours, cleaned up codespell whitelist entriesdocs/templates/function_parameter_datatable.html.j2: Jinja2 template for rendering function parameter documentationConfiguration Updates:
tox.iniwith new documentation environments and proper dependenciesmkdocstrings[python], etc.) to documentation extrasBenefits
Usage
🔗 Related Issues or PRs
Part of the WELD milestone (❄️ WELD Freeze ❄️)
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e statictype(scope):.mkdocs servelocallyand verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned@ported_frommarker.:::with the new package pathswhitelist word1 word2)Cute Animal Picture
Credit to Linnaea Mallette:
License: CC0 Public Domain