Skip to content

chore: remove weld migration warnings#1658

Merged
fselmo merged 1 commit into
ethereum:forks/osakafrom
fselmo:fix/remove-migration-msgs
Oct 22, 2025
Merged

chore: remove weld migration warnings#1658
fselmo merged 1 commit into
ethereum:forks/osakafrom
fselmo:fix/remove-migration-msgs

Conversation

@fselmo

@fselmo fselmo commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

🗒️ Description

Removes migration warnings when using uv + execute, consume, fill.

Compare with ethereum/execution-spec-tests#2302 for changeset

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@fselmo fselmo marked this pull request as ready for review October 22, 2025 19:08
@fselmo fselmo requested review from SamWilsn and marioevz October 22, 2025 19:08

@marioevz marioevz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fselmo fselmo merged commit da0c26e into ethereum:forks/osaka Oct 22, 2025
10 checks passed
@fselmo fselmo deleted the fix/remove-migration-msgs branch October 22, 2025 19:20
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.08%. Comparing base (fe377e7) to head (d4030ae).
⚠️ Report is 647 commits behind head on forks/osaka.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           forks/osaka    #1658   +/-   ##
============================================
  Coverage        86.08%   86.08%           
============================================
  Files              743      743           
  Lines            44072    44072           
  Branches          3891     3891           
============================================
  Hits             37938    37938           
  Misses            5656     5656           
  Partials           478      478           
Flag Coverage Δ
unittests 86.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

chetna-mittal pushed a commit to gnosischain/execution-specs that referenced this pull request Oct 24, 2025
* zkevm: calldataload

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* fix assertion

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* avoid POPs

* rebase

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* generalize calldata argument

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

---------

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants