chore(weld): ruff 79 line length alignment by spencer-tb · Pull Request #1649 · ethereum/execution-specs

spencer-tb · 2025-10-21T16:47:47Z

🗒️ Description

Updates packages/tests and src/tests with the ruff line length of 79 (and other ruff related changes).

Note uvx --with=tox-uv tox -e static passes mypy/ruff now!

Closes ethereum/execution-spec-tests#2199

🔗 Related Issues or PRs

N/A.

✅ Checklist

All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
```
uvx --with=tox-uv tox -e static
```
All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
All: Considered adding an entry to CHANGELOG.md.
All: Considered updating the online docs in the ./docs/ directory.
All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

spencer-tb · 2025-10-21T18:01:26Z

Can someone check fill still works please? So I've not broken anything... or maybe we can wait for tests-develop tox env/CI workflow :)

marioevz

Amazing! Thanks for this.

danceratopz

Thanks @spencer-tb! I think the suggestion below will fix-up filling the tests.

danceratopz · 2025-10-21T20:25:37Z

+    ## Curve Coefficient
+    B = 0x5AC635D8AA3A93E7B3EBBD55769886BC651D06B0CC53B0F63BCE3C3E27D2604B
+    ## Subgroup Order
+    N = 0xFFFFFFFF0000000FFFFFFFFFFFFFFFFBCE6FAADA7179E84F3B9CAC2FC632551


Sneaky!

Suggested change

N = 0xFFFFFFFF0000000FFFFFFFFFFFFFFFFBCE6FAADA7179E84F3B9CAC2FC632551

N = 0xFFFFFFFF00000000FFFFFFFFFFFFFFFFBCE6FAADA7179E84F3B9CAC2FC632551

What happened here? 👀

Don't know, bit scary. Worth verifying fixtures via hasher to make sure nothing more subtle has crept in (not only for this PR).

I committed the change to trigger the CI flow.

lol sry! I was editing with vim mode so probably a missed typed "x" that removed the 0

codecov-commenter · 2025-10-22T01:59:12Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.08%. Comparing base (6383d7b) to head (ecff389).
⚠️ Report is 5 commits behind head on forks/osaka.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##           forks/osaka    #1649   +/-   ##
============================================
  Coverage        86.08%   86.08%           
============================================
  Files              743      743           
  Lines            44072    44072           
  Branches          3891     3891           
============================================
  Hits             37938    37938           
  Misses            5656     5656           
  Partials           478      478

Flag	Coverage Δ
unittests	`86.08% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

LouisTsai-Csie · 2025-10-22T06:27:19Z

Amazing!! There are more than 2K+ error originally

…e_size()` from fork config (ethereum#1649) * feat(forks): introduce max code size / max initcode size * feat(tests): read max code size from fork / scale gas limit as appropriate for test * Update src/ethereum_test_forks/base_fork.py Co-authored-by: Paweł Bylica <chfast@gmail.com> * Update src/ethereum_test_forks/base_fork.py Co-authored-by: Paweł Bylica <chfast@gmail.com> * Update src/ethereum_test_forks/forks/forks.py Co-authored-by: Paweł Bylica <chfast@gmail.com> * feat(tests): fix type error complaints * feat(tests): make tests dependent on MAX_CODE_SIZE now depend on the fork-based max code size * feat(tests): use a more logical gas limit formula for contract deployment * feat(tests): default (init)code size limit to first limit set * feat(tests): remove EIP 7907 from Osaka * feat(tests): make typecheck happy * feat(tests): do not use fallback for code size being returned `None` anymore * feat(tests): read code size from forks from newly added tests after rebase * Update tests/zkevm/test_worst_bytecode.py Co-authored-by: Mario Vega <marioevz@gmail.com> * feat(tests): insert max_code_size for modarith zkevm test --------- Co-authored-by: Paweł Bylica <chfast@gmail.com> Co-authored-by: Mario Vega <marioevz@gmail.com>

spencer-tb · 2025-10-22T08:01:20Z

Checking hasher then will merge afterwards.

spencer-tb · 2025-10-22T09:23:39Z

Root hashes are the same between filling from EELS on this branch and with EEST.

…e_size()` from fork config (ethereum#1649) * feat(forks): introduce max code size / max initcode size * feat(tests): read max code size from fork / scale gas limit as appropriate for test * Update src/ethereum_test_forks/base_fork.py Co-authored-by: Paweł Bylica <chfast@gmail.com> * Update src/ethereum_test_forks/base_fork.py Co-authored-by: Paweł Bylica <chfast@gmail.com> * Update src/ethereum_test_forks/forks/forks.py Co-authored-by: Paweł Bylica <chfast@gmail.com> * feat(tests): fix type error complaints * feat(tests): make tests dependent on MAX_CODE_SIZE now depend on the fork-based max code size * feat(tests): use a more logical gas limit formula for contract deployment * feat(tests): default (init)code size limit to first limit set * feat(tests): remove EIP 7907 from Osaka * feat(tests): make typecheck happy * feat(tests): do not use fallback for code size being returned `None` anymore * feat(tests): read code size from forks from newly added tests after rebase * Update tests/zkevm/test_worst_bytecode.py Co-authored-by: Mario Vega <marioevz@gmail.com> * feat(tests): insert max_code_size for modarith zkevm test --------- Co-authored-by: Paweł Bylica <chfast@gmail.com> Co-authored-by: Mario Vega <marioevz@gmail.com>

spencer-tb added A-test-tests Area: tests for packages/testing A-test-specs Area: execution_testing.specs Finalize Weld labels Oct 21, 2025

spencer-tb added 10 commits October 21, 2025 18:48

chore(tests): ruff lint 99 tests check --fix

e551d01

chore(tests): ruff lint 99 tests format

4ed3161

chore(tests): arg001 ignore to root toml and package toml to line 79

a32415a

chore(packages): packages/tests/src to line length 79

e0b1ad4

chore(packages): packages/tests/src post mypy fixes

b9685a0

chore(tests): ruff lint 79 tests check --fix

578b674

chore(tests): ruff lint 79 tests format

97d12db

chore(tests): ruff lint 79 extras... this was a pain

170f627

chore(tests): revert accidental json_tests changes

a1b6a78

chore(tox): update tox static env

2b2e7db

spencer-tb force-pushed the ruff-linting-final branch from 8db4d89 to 2b2e7db Compare October 21, 2025 17:49

spencer-tb marked this pull request as ready for review October 21, 2025 17:49

marioevz approved these changes Oct 21, 2025

View reviewed changes

danceratopz reviewed Oct 21, 2025

View reviewed changes

chore(tests): fix typo

3eac33a

danceratopz force-pushed the ruff-linting-final branch from ecff389 to 3eac33a Compare October 22, 2025 06:00

spencer-tb merged commit 8ac541c into ethereum:forks/osaka Oct 22, 2025
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(weld): ruff 79 line length alignment#1649

chore(weld): ruff 79 line length alignment#1649
spencer-tb merged 11 commits into
ethereum:forks/osakafrom
spencer-tb:ruff-linting-final

spencer-tb commented Oct 21, 2025 •

edited by danceratopz

Loading

Uh oh!

spencer-tb commented Oct 21, 2025 •

edited

Loading

Uh oh!

marioevz left a comment

Uh oh!

danceratopz left a comment

Uh oh!

danceratopz Oct 21, 2025

Uh oh!

marioevz Oct 21, 2025

Uh oh!

danceratopz Oct 21, 2025

Uh oh!

danceratopz Oct 21, 2025

Uh oh!

spencer-tb Oct 21, 2025

Uh oh!

codecov-commenter commented Oct 22, 2025

Uh oh!

LouisTsai-Csie commented Oct 22, 2025

Uh oh!

spencer-tb commented Oct 22, 2025

Uh oh!

spencer-tb commented Oct 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	N = 0xFFFFFFFF0000000FFFFFFFFFFFFFFFFBCE6FAADA7179E84F3B9CAC2FC632551
	N = 0xFFFFFFFF00000000FFFFFFFFFFFFFFFFBCE6FAADA7179E84F3B9CAC2FC632551

Conversation

spencer-tb commented Oct 21, 2025 • edited by danceratopz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🗒️ Description

🔗 Related Issues or PRs

✅ Checklist

Cute Animal Picture

Uh oh!

spencer-tb commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marioevz left a comment

Choose a reason for hiding this comment

Uh oh!

danceratopz left a comment

Choose a reason for hiding this comment

Uh oh!

danceratopz Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

marioevz Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

danceratopz Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

danceratopz Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

spencer-tb Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Oct 22, 2025

Codecov Report

Uh oh!

LouisTsai-Csie commented Oct 22, 2025

Uh oh!

spencer-tb commented Oct 22, 2025

Uh oh!

spencer-tb commented Oct 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

spencer-tb commented Oct 21, 2025 •

edited by danceratopz

Loading

spencer-tb commented Oct 21, 2025 •

edited

Loading