type:refactor Change is_after_fork method #1448
Merged
SamWilsn merged 1 commit intoethereum:forks/osakafrom Oct 3, 2025
Merged
type:refactor Change is_after_fork method #1448SamWilsn merged 1 commit intoethereum:forks/osakafrom
is_after_fork method #1448SamWilsn merged 1 commit intoethereum:forks/osakafrom
Conversation
SamWilsn
requested changes
Oct 2, 2025
Contributor
SamWilsn
left a comment
There was a problem hiding this comment.
You'll also want to change anywhere that calls is_after_fork, or else things will break.
| return_value = False | ||
| for fork in self._forks: | ||
| if fork.name == target_fork_name: | ||
| short_name = fork.name.split(".")[-1] |
Contributor
Author
Okay, noted. Changes have now been applied. Kindly review. |
79d585c to
e450113
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1448 +/- ##
============================================
Coverage 86.08% 86.08%
============================================
Files 743 743
Lines 44072 44072
Branches 3891 3891
============================================
Hits 37938 37938
Misses 5656 5656
Partials 478 478
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SamWilsn
approved these changes
Oct 3, 2025
danceratopz
pushed a commit
to danceratopz/execution-specs
that referenced
this pull request
Oct 22, 2025
…thereum#1448) Convert all EOF validation tests for EIP-4200 (relative jumps) to use `max_stack_increase`. The conversion here is simple because all these tests use the code section 0 and therefore `max_stack_increase` is equivalent to `max_stack_height`.
SamWilsn
pushed a commit
that referenced
this pull request
Dec 9, 2025
…1448) Convert all EOF validation tests for EIP-4200 (relative jumps) to use `max_stack_increase`. The conversion here is simple because all these tests use the code section 0 and therefore `max_stack_increase` is equivalent to `max_stack_height`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR refactors the
ForkLoad.is_after_forkmethod to accept fork short names (e.g."Paris","Shanghai") instead of full module paths (e.g."ethereum.forks.paris").🔗 Related Issues or PRs
N/A.
Fixes #1424
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture