Skip to content

feat(tests): EIP-7702: test set code tx ideas implementation#981

Merged
marioevz merged 13 commits intomainfrom
eip7702
Jan 23, 2025
Merged

feat(tests): EIP-7702: test set code tx ideas implementation#981
marioevz merged 13 commits intomainfrom
eip7702

Conversation

@winsvega
Copy link
Copy Markdown

@winsvega winsvega commented Dec 2, 2024

🗒️ Description

Write tests for ideas from the issue

🔗 Related Issues

#952

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@winsvega winsvega added scope:pytest Scope: Changes EEST's pytest plugins type:test Type: Add/refactor fw unit tests; no fw or el client test case changes labels Dec 2, 2024
@winsvega winsvega self-assigned this Dec 2, 2024
@winsvega winsvega force-pushed the eip7702 branch 3 times, most recently from 7524711 to 5009dda Compare December 2, 2024 14:28
@winsvega winsvega changed the title test set code tx ideas test set code tx ideas implementation Dec 2, 2024
Copy link
Copy Markdown
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests look good to me, just some comments.

@danceratopz danceratopz added the fork:prague Prague hardfork label Dec 2, 2024
@winsvega winsvega force-pushed the eip7702 branch 2 times, most recently from 8fb3439 to 5d0179e Compare December 4, 2024 10:55
@winsvega winsvega changed the title test set code tx ideas implementation feat(tests): test set code tx ideas implementation part1 Dec 4, 2024
@winsvega winsvega requested a review from marioevz December 4, 2024 11:16
@winsvega winsvega force-pushed the eip7702 branch 4 times, most recently from b01c835 to 64aa914 Compare December 16, 2024 09:39
@winsvega winsvega force-pushed the eip7702 branch 2 times, most recently from 9ab093f to 3418a0b Compare December 18, 2024 12:17
@winsvega winsvega changed the title feat(tests): test set code tx ideas implementation part1 feat(tests): test set code tx ideas implementation Dec 19, 2024
@winsvega winsvega force-pushed the eip7702 branch 2 times, most recently from 79138c4 to 54b4886 Compare December 19, 2024 11:25
@winsvega winsvega force-pushed the eip7702 branch 3 times, most recently from 47605ed to fe964b3 Compare January 21, 2025 10:47
Copy link
Copy Markdown
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not finish the review, but I have some comments so far. Overall I think it's a nice addition to the 7702 test set 👍

@marioevz marioevz mentioned this pull request Jan 23, 2025
@winsvega winsvega force-pushed the eip7702 branch 2 times, most recently from 37f3baa to d9bd4ce Compare January 23, 2025 12:17
Copy link
Copy Markdown
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for implementing this!

@marioevz marioevz changed the title feat(tests): test set code tx ideas implementation feat(tests): EIP-7702: test set code tx ideas implementation Jan 23, 2025
@marioevz marioevz merged commit 4412007 into main Jan 23, 2025
@marioevz marioevz deleted the eip7702 branch January 23, 2025 14:47
fselmo pushed a commit to fselmo/execution-spec-tests that referenced this pull request Jan 24, 2025
…m#981)

* test set code tx ideas

* address comments

* changelog

* 7702 gas measure

* make black happy

* storage modifications, static context

* clarify gas prices

* reentrancy test

* revert scenarios

* suicide a pointer that points to newly created account

* fix Ruff

* apply suggestions

* Update tests/prague/eip7702_set_code_tx/test_set_code_txs_2.py

---------

Co-authored-by: Mario Vega <marioevz@gmail.com>
kclowes pushed a commit to kclowes/execution-spec-tests that referenced this pull request Oct 20, 2025
…m#981)

* test set code tx ideas

* address comments

* changelog

* 7702 gas measure

* make black happy

* storage modifications, static context

* clarify gas prices

* reentrancy test

* revert scenarios

* suicide a pointer that points to newly created account

* fix Ruff

* apply suggestions

* Update tests/prague/eip7702_set_code_tx/test_set_code_txs_2.py

---------

Co-authored-by: Mario Vega <marioevz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork:prague Prague hardfork scope:pytest Scope: Changes EEST's pytest plugins type:test Type: Add/refactor fw unit tests; no fw or el client test case changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants