refactor(all): Enforce all execution-specs mypy rules#2281
Merged
Conversation
67735eb to
0195a0f
Compare
Collaborator
|
@marioevz i've pushed all my changes. We have reduced the number to only 5 remaining file! Currently there is one failure for |
Member
Author
|
Split |
0e2738e to
707d91c
Compare
e2c14ad to
7f6c378
Compare
refactor(tests/osaka): More fixes
refactor(tests/prague): More fixes
… rule refactor(clis): More fixes
refactor(plugins/forks): More fixes
refactor(plugins/solc): More fixes
…cs mypy rule refactor(plugins/eels_resolver): More fixes
…tion-specs mypy rule
…y rule refactor(plugins/execute): More fixes
… rule refactor(plugins/filler): More fixes
…ion-specs mypy rule
3f82726 to
1340551
Compare
Member
Author
|
I've diff'd the fixtures before and after this PR using the following fill command: uv run fill --output ../fixtures.base/ --until=Prague -m "not slow" -n autoAnd then diff'd using ➜ execution-spec-tests git:(main) uv run hasher -r ../fixtures.base
0x6638cacbd017bc997fde90573b33d0eda091ce9f164eeb7c161d2b3e1dd087da
➜ execution-spec-tests git:(main) uv run hasher -r ../fixtures.patch
0x6638cacbd017bc997fde90573b33d0eda091ce9f164eeb7c161d2b3e1dd087daAnd both resulted in the exact same output, which means that the fixture generation was correctly unaffected by this PR and we should be able to proceed and merge. The issue in https://github.com/ethereum/execution-spec-tests/actions/runs/18390717568/job/52400137583?pr=2281 might be related to evmone (it fails during the execution of tests from the main branch, not the PR), but it seems to me that it's outside of the scope of this PR. We could create an issue on the evmone repository to follow this up. |
fselmo
approved these changes
Oct 9, 2025
kclowes
pushed a commit
to kclowes/execution-spec-tests
that referenced
this pull request
Oct 20, 2025
* refactor(pyproject): Enforce all execution-specs mypy rules * refactor(base_types): Enforce all execution-specs mypy rules * refactor(types): Enforce all execution-specs mypy rules * refactor(vm): Enforce all execution-specs mypy rules * refactor(forks): Enforce all execution-specs mypy rules * refactor(tests/shanghai): Enforce all execution-specs mypy rules * refactor(fixtures): Enforce all execution-specs mypy rules * refactor(tests/benchmark): Enforce all execution-specs mypy rules * refactor(tests/osaka): Enforce all execution-specs mypy rules refactor(tests/osaka): More fixes * refactor(tests/prague): Enforce all execution-specs mypy rules refactor(tests/prague): More fixes * refactor(tests/cancun): Enforce all execution-specs mypy rules * refactor(tests/homestead): Enforce all execution-specs mypy rules * refactor(tests/frontier): Enforce all execution-specs mypy rules * refactor(tests/istanbul): Enforce all execution-specs mypy rules * refactor(tests/constantinople): Enforce all execution-specs mypy rules * refactor(tests/berlin): Enforce all execution-specs mypy rules * refactor(tests/byzantium): Enforce all execution-specs mypy rules * refactor(tests/paris): Enforce all execution-specs mypy rules * refactor(tests/amsterdam): Enforce all execution-specs mypy rules * refactor(tests/unscheduled): Enforce all execution-specs mypy rules * fix linting issue * refactor(src/ethereum_test_exceptions): Enforce all execution-specs mypy rules * refactor(.github/scripts): Enforce all execution-specs mypy rules * fix typing issue after rebase * refactor(src/ethereum_test_tools): Enforce all execution-specs mypy rules * refactor(src/config): Enforce all execution-specs mypy rules * refactor(src/ethereum_test_checklists): Enforce all execution-specs mypy rules * refactor(src/ethereum_test_rpc): Enforce all execution-specs mypy rules * fix issue after rebase * refactor(specs): Enforce all execution-specs mypy rules * refactor(src/cli,src/ethereum_clis): Enforce all execution-specs mypy rule refactor(clis): More fixes * refactor(src/ethereum_test_execution): Enforce all execution-specs mypy rule * refactor(plugins/forks): Enforce all execution-specs mypy rules refactor(plugins/forks): More fixes * refactor(plugins/logging): Enforce all execution-specs mypy rules * refactor(src/pytest_plugins/solc): Enforce all execution-specs mypy rule refactor(plugins/solc): More fixes * refactor(src/pytest_plugins/help): Enforce all execution-specs mypy rule * refactor(src/pytest_plugins/eels_resolver): Enforce all execution-specs mypy rule refactor(plugins/eels_resolver): More fixes * refactor(src/pytest_plugins/fix_package_test_path): Enforce all execution-specs mypy rule * refactor(src/pytest_plugins/execute): Enforce all execution-specs mypy rule refactor(plugins/execute): More fixes * refactor(plugins/consume): Enforce all execution-specs mypy rules * refactor(src/pytest_plugins/filler): Enforce all execution-specs mypy rule refactor(plugins/filler): More fixes * refactor(src/pytest_plugins/spec_version_checker): Enforce all execution-specs mypy rule * refactor(src/pytest_plugins/pytest_hive): Enforce all execution-specs mypy rule * refactor(plugins/shared): Enforce all execution-specs mypy rules --------- Co-authored-by: LouisTsai <q1030176@gmail.com> Co-authored-by: fselmo <fselmo2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This is a collaborative branch/PR to distribute the work required to fix all broken mypy rules.
Instructions
eels-mypy-rules) locallyuv run --with=mypy mypy path/to/folderto verify the errors locally.Try usingUse claude's prompt below to start the type fixing process.uv run --with libcst add_none_returns.py path/to/folderfirst to see if it fixes most of the issues.uvx --with=tox-uv tox -e lint,pytestto verify that everything is still working.refactor(path/to/folder): Enforce all execution-specs mypy ruleswhen possible so we can rebase merge this PR).Claude Prompt
Work Folders
🔗 Related Issues or PRs
Fixes ethereum/execution-specs#1477
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.