refactor(tests): use relative imports in ./tests#1848
Merged
Conversation
da97580 to
218a340
Compare
danceratopz
approved these changes
Jul 3, 2025
danceratopz
left a comment
Member
There was a problem hiding this comment.
Awesome, thanks for jumping straight on this one!
I'd say let's get this merged as-is for ./tests and potentially on to the next for ./src/.
gurukamath
approved these changes
Jul 3, 2025
Collaborator
There was a problem hiding this comment.
LGTM! Perhaps it is an overkill here but we do have a custom lint that enforces this in our CI. See this if interested.
./tests
8 tasks
8 tasks
kclowes
added a commit
to kclowes/execution-spec-tests
that referenced
this pull request
Oct 20, 2025
Co-authored-by: danceratopz <danceratopz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Use only relative imports in the
tests/directory. @gurukamath or @danceratopz let me know if there is more work to do here in other directories as well.🔗 Related Issues or PRs
Fixes #1844
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.