benchmark: add 0-param opcodes coverage#1698
Merged
Merged
Conversation
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
9 tasks
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Collaborator
Author
|
@jochem-brouwer, ready if you want to take a look! :) |
jochem-brouwer
requested changes
Jun 2, 2025
jochem-brouwer
left a comment
Member
There was a problem hiding this comment.
Some points, mainly about style, and I think some opcodes are missing (but might be handled by other tests I am not aware of)
Co-authored-by: Jochem Brouwer <jochembrouwer96@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
1d0afcb to
e449eff
Compare
jochem-brouwer
requested changes
Jun 2, 2025
jochem-brouwer
left a comment
Member
There was a problem hiding this comment.
Some minor comments 😄 Will leave the "move repeated code to helper methods" for indeed a later "big refactor/cleanup" 😄 👍
Co-authored-by: Jochem Brouwer <jochembrouwer96@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
jochem-brouwer
approved these changes
Jun 2, 2025
jochem-brouwer
left a comment
Member
There was a problem hiding this comment.
I have two small comments, feel free to address, but will also approve here. LGTM.
Collaborator
Author
Thank you! Were addressed. I'll wait for the CI to be green again and merge. |
This was referenced Jun 11, 2025
kclowes
pushed a commit
to kclowes/execution-spec-tests
that referenced
this pull request
Oct 20, 2025
* zkevm: add generic zero-param opcodes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * zkevm: add CALLVALUE coverage Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * add comment Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * zkevm: add RETURNDATASIZE coverage Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * zkevm: add MSIZE coverage & fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * change params Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * Update tests/zkevm/test_worst_compute.py Co-authored-by: Jochem Brouwer <jochembrouwer96@gmail.com> * feedback Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * add comment Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * generalize returndata test Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fix Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * Update tests/zkevm/test_worst_compute.py Co-authored-by: Jochem Brouwer <jochembrouwer96@gmail.com> * separate RETURNDATASIZE tests Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * nit Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> Co-authored-by: Jochem Brouwer <jochembrouwer96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds coverage for many 0-param opcodes.
Cycles:
Close #1651