Skip to content

chore(deps): upgrade ethereum-types to 0.2.3#1154

Merged
danceratopz merged 1 commit intomainfrom
upgrade-ethereum-types
Jan 29, 2025
Merged

chore(deps): upgrade ethereum-types to 0.2.3#1154
danceratopz merged 1 commit intomainfrom
upgrade-ethereum-types

Conversation

@marioevz
Copy link
Copy Markdown
Member

@marioevz marioevz commented Jan 29, 2025 •
edited
Loading

🗒️ Description

Upgrades ethereum-types to the latest version: 0.2.3

Fixes issue when running the resolver:

Traceback (most recent call last):
  File "/home/marioevz/Development/Eth/execution-spec-tests/.venv/bin/ethereum-spec-evm-resolver", line 8, in <module>
    sys.exit(main())
  File "/home/marioevz/Development/Eth/execution-spec-tests/.venv/lib/python3.10/site-packages/ethereum_spec_evm_resolver/main.py", line 53, in main
    from ethereum_spec_tools.evm_tools import Daemon as Daemon_
  File "/home/marioevz/Development/Eth/z-execution-specs/src/ethereum_spec_tools/evm_tools/__init__.py", line 12, in <module>
    from .b11r import B11R, b11r_arguments
  File "/home/marioevz/Development/Eth/z-execution-specs/src/ethereum_spec_tools/evm_tools/b11r/__init__.py", line 15, in <module>
    from .b11r_types import Body, Header
  File "/home/marioevz/Development/Eth/z-execution-specs/src/ethereum_spec_tools/evm_tools/b11r/b11r_types.py", line 12, in <module>
    from ethereum.utils.hexadecimal import hex_to_bytes, hex_to_bytes8
  File "/home/marioevz/Development/Eth/z-execution-specs/src/ethereum/utils/hexadecimal.py", line 15, in <module>
    from ethereum_types.numeric import U8, U64, U256, Uint
ImportError: cannot import name 'U8' from 'ethereum_types.numeric' (/home/marioevz/Development/Eth/execution-spec-tests/.venv/lib/python3.10/site-packages/ethereum_types/numeric.py)

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz requested a review from danceratopz January 29, 2025 19:36
@marioevz marioevz added type:bug Something isn't working scope:evm Scope: evm_transition_tool package type:chore Type: Chore labels Jan 29, 2025
@marioevz marioevz mentioned this pull request Jan 29, 2025
Closed
10 tasks
danceratopz
danceratopz approved these changes Jan 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this is probably another dependency that should be added to the resolver.

@danceratopz danceratopz merged commit 9f6d89d into main Jan 29, 2025
@danceratopz danceratopz deleted the upgrade-ethereum-types branch January 29, 2025 20:43
@danceratopz danceratopz added the scope:deps Scope: Updates package dependencies label Jan 29, 2025
@danceratopz danceratopz changed the title uv.lock: Upgrade ethereum-types to 0.2.3 chore(deps): upgrade ethereum-types to 0.2.3 Jan 29, 2025
marioevz added a commit to marioevz/execution-spec-tests that referenced this pull request Jan 30, 2025
@marioevz
chore(deps): upgrade ethereum-types to 0.2.3 (ethereum#1154)
ef99e20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danceratopz danceratopz danceratopz approved these changes

Assignees

No one assigned

Labels

scope:deps Scope: Updates package dependencies scope:evm Scope: evm_transition_tool package type:bug Something isn't working type:chore Type: Chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marioevz @danceratopz