refactor(forks): suggestions for fork transition marker changes#1104
Merged
marioevz merged 2 commits intofork-transition-test-markerfrom Jan 22, 2025
Merged
Conversation
8 tasks
marioevz
added a commit
that referenced
this pull request
Jan 22, 2025
* feat(forks): Adds `supports_blobs` method * fix(forks): Transition fork comparisons * refactor,fix(plugins/forks): `fork_transition_test` marker * docs: add documentation, changelog * refactor(plugins/forks): Validity markers as classes * fix: fork set handling * fix(plugins): config variable usage in other plugins * fix(plugins/forks): Self-documenting code for validity marker classes * whitelist * refactor(forks): suggestions for fork transition marker changes (#1104) * refactor(forks): make `name()` an abstractmethod * refactor(forks): add helper methods to simplify fork comparisons * Update src/pytest_plugins/forks/forks.py Co-authored-by: danceratopz <danceratopz@gmail.com> * Update src/pytest_plugins/forks/forks.py Co-authored-by: danceratopz <danceratopz@gmail.com> * Update src/pytest_plugins/forks/forks.py Co-authored-by: danceratopz <danceratopz@gmail.com> * fixup --------- Co-authored-by: danceratopz <danceratopz@gmail.com>
fselmo
pushed a commit
to fselmo/execution-spec-tests
that referenced
this pull request
Jan 24, 2025
* feat(forks): Adds `supports_blobs` method * fix(forks): Transition fork comparisons * refactor,fix(plugins/forks): `fork_transition_test` marker * docs: add documentation, changelog * refactor(plugins/forks): Validity markers as classes * fix: fork set handling * fix(plugins): config variable usage in other plugins * fix(plugins/forks): Self-documenting code for validity marker classes * whitelist * refactor(forks): suggestions for fork transition marker changes (ethereum#1104) * refactor(forks): make `name()` an abstractmethod * refactor(forks): add helper methods to simplify fork comparisons * Update src/pytest_plugins/forks/forks.py Co-authored-by: danceratopz <danceratopz@gmail.com> * Update src/pytest_plugins/forks/forks.py Co-authored-by: danceratopz <danceratopz@gmail.com> * Update src/pytest_plugins/forks/forks.py Co-authored-by: danceratopz <danceratopz@gmail.com> * fixup --------- Co-authored-by: danceratopz <danceratopz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestions for #1081.