feat(tests): EIP-7691: Fork transition tests by marioevz · Pull Request #1082 · ethereum/execution-spec-tests

marioevz · 2025-01-16T01:03:16Z

🗒️ Description

Implements fork transition tests for the blob target and max increment by EIP-7691 that occurs on the Prague activation.

Test expectation: At the first block of Prague, we use theTARGET_BLOB_GAS_PER_BLOCK,MAX_BLOB_GAS_PER_BLOCK and BLOB_BASE_FEE_UPDATE_FRACTION_PRAGUE constants in EIP-7691, just the same as we use for subsequent blocks for Prague:

tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py::test_fork_transition_excess_blob_gas_at_blob_genesis[fork_ShanghaiToCancunAtTime15k-max_blobs-blockchain_test]
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py::test_fork_transition_excess_blob_gas_at_blob_genesis[fork_ShanghaiToCancunAtTime15k-max_blobs-blockchain_test_engine]
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py::test_fork_transition_excess_blob_gas_at_blob_genesis[fork_ShanghaiToCancunAtTime15k-no_blobs-blockchain_test]
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py::test_fork_transition_excess_blob_gas_at_blob_genesis[fork_ShanghaiToCancunAtTime15k-no_blobs-blockchain_test_engine]
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py::test_fork_transition_excess_blob_gas_at_blob_genesis[fork_ShanghaiToCancunAtTime15k-target_blobs-blockchain_test]
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py::test_fork_transition_excess_blob_gas_at_blob_genesis[fork_ShanghaiToCancunAtTime15k-target_blobs-blockchain_test_engine]
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py::test_fork_transition_excess_blob_gas_post_blob_genesis[fork_CancunToPragueAtTime15k-max_blobs-blockchain_test]
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py::test_fork_transition_excess_blob_gas_post_blob_genesis[fork_CancunToPragueAtTime15k-max_blobs-blockchain_test_engine]
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py::test_fork_transition_excess_blob_gas_post_blob_genesis[fork_CancunToPragueAtTime15k-no_blobs_before-blockchain_test]
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py::test_fork_transition_excess_blob_gas_post_blob_genesis[fork_CancunToPragueAtTime15k-no_blobs_before-blockchain_test_engine]
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py::test_fork_transition_excess_blob_gas_post_blob_genesis[fork_CancunToPragueAtTime15k-no_blobs_after-blockchain_test]
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py::test_fork_transition_excess_blob_gas_post_blob_genesis[fork_CancunToPragueAtTime15k-no_blobs_after-blockchain_test_engine]
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py::test_fork_transition_excess_blob_gas_post_blob_genesis[fork_CancunToPragueAtTime15k-target_blobs-blockchain_test]
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py::test_fork_transition_excess_blob_gas_post_blob_genesis[fork_CancunToPragueAtTime15k-target_blobs-blockchain_test_engine]
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py::test_fork_transition_excess_blob_gas_post_blob_genesis[fork_CancunToPragueAtTime15k-single_blob_to_max_blobs-blockchain_test]
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py::test_fork_transition_excess_blob_gas_post_blob_genesis[fork_CancunToPragueAtTime15k-single_blob_to_max_blobs-blockchain_test_engine]
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py::test_fork_transition_excess_blob_gas_post_blob_genesis[fork_CancunToPragueAtTime15k-max_blobs_to_single_blob-blockchain_test]
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py::test_fork_transition_excess_blob_gas_post_blob_genesis[fork_CancunToPragueAtTime15k-max_blobs_to_single_blob-blockchain_test_engi

(output generated with fill --until Prague -k test_fork_transition_excess_blob_gas --collect-only -q)

~~Requires #1081~~ Merged

🔗 Related Issues

None

✅ Checklist

All: Set appropriate labels for the changes.
All: Considered squashing commits to improve commit history.
All: Added an entry to CHANGELOG.md.

…in newer forks

marioevz · 2025-01-22T18:14:28Z

Documenting here the drop in coverage when comparing the generated fixtures by this PR against main:

The culprit is that we were originally sending the blob transactions to a hard-coded empty address at Address(0x100) here:

execution-spec-tests/tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py

Lines 72 to 74 in 607d1b6

    
           @pytest.fixture 
        
           def destination_account() -> Address:  # noqa: D103 
        
               return Address(0x100)

And was changed in this PR to a new dynamically generated contract with a single STOP opcode here:

execution-spec-tests/tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py

Lines 133 to 135 in 773e5c3

    
           @pytest.fixture 
        
           def destination_account(pre: Alloc) -> Address:  # noqa: D103 
        
               return pre.deploy_contract(Op.STOP)

Since this test has nothing to do with empty accounts, I think this should be ok.

Coverage check doing its job very nicely here because if it was something else that was a bit more serious, it would have been caught here 💯

danceratopz

Looks great!

These tests all pass consume direct with s1na/go-ethereum@f24d6f6

Not particular to the changes here (the tests were already so): The tests include type2 tx before the transition and then type3 tx after (no type2). I wondered if we should include type2 after transition as well, in addtion to the new type3 txs?

One other comment below.

tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py

* feat(tests): more edge cases for blob gas at transitions * Apply suggestions from code review --------- Co-authored-by: Mario Vega <marioevz@gmail.com>

danceratopz

LGTM!

marioevz · 2025-01-22T21:22:31Z

Lost of coverage in the last commit is due to removal of Type-2 transactions, which are not the purpose of this test:

* refactor(tests): EIP-4844, EIP-7691: Fill fork transition blob tests in newer forks * fix(tests): Rebase fixes, add more checks to the test * chengelog * feat(tests): more blob gas tests for fork transitions (ethereum#1107) * feat(tests): more edge cases for blob gas at transitions * Apply suggestions from code review --------- Co-authored-by: Mario Vega <marioevz@gmail.com> * fix(tests): Remove type-2 txs, destination account is empty * tox: typing --------- Co-authored-by: danceratopz <danceratopz@gmail.com>

marioevz force-pushed the fork-transition-eip-7691 branch from f0c84de to 3f4df0f Compare January 16, 2025 12:52

marioevz mentioned this pull request Jan 20, 2025

Prague Devnet-5 Release 1.3.0 Tracker #1094

Closed

16 tasks

marioevz force-pushed the fork-transition-eip-7691 branch from 3f4df0f to c0c27f3 Compare January 20, 2025 23:01

danceratopz mentioned this pull request Jan 22, 2025

feat(forks,specs,fixtures): add eip-7840 blob schedule config #1040

Merged

8 tasks

marioevz added 2 commits January 22, 2025 17:36

refactor(tests): EIP-4844, EIP-7691: Fill fork transition blob tests …

2c9cce9

…in newer forks

fix(tests): Rebase fixes, add more checks to the test

791a6ae

marioevz force-pushed the fork-transition-eip-7691 branch from c0c27f3 to 791a6ae Compare January 22, 2025 17:37

chengelog

773e5c3

danceratopz added scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature labels Jan 22, 2025

danceratopz mentioned this pull request Jan 22, 2025

feat(tests): more blob gas tests for fork transitions #1107

Merged

2 tasks

danceratopz reviewed Jan 22, 2025

View reviewed changes

tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py Show resolved Hide resolved

feat(tests): more blob gas tests for fork transitions (#1107)

3642881

* feat(tests): more edge cases for blob gas at transitions * Apply suggestions from code review --------- Co-authored-by: Mario Vega <marioevz@gmail.com>

danceratopz approved these changes Jan 22, 2025

View reviewed changes

marioevz added 2 commits January 22, 2025 21:09

fix(tests): Remove type-2 txs, destination account is empty

41f00a1

tox: typing

2d8bd02

marioevz merged commit 5e6a38e into main Jan 22, 2025

marioevz deleted the fork-transition-eip-7691 branch January 22, 2025 21:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(tests): EIP-7691: Fork transition tests#1082

feat(tests): EIP-7691: Fork transition tests#1082
marioevz merged 6 commits intomainfrom
fork-transition-eip-7691

marioevz commented Jan 16, 2025 •

edited by danceratopz

Loading

Uh oh!

marioevz commented Jan 22, 2025 •

edited

Loading

Uh oh!

danceratopz left a comment

Uh oh!

Uh oh!

danceratopz left a comment

Uh oh!

marioevz commented Jan 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

marioevz commented Jan 16, 2025 • edited by danceratopz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🗒️ Description

🔗 Related Issues

✅ Checklist

Uh oh!

marioevz commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danceratopz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

danceratopz left a comment

Choose a reason for hiding this comment

Uh oh!

marioevz commented Jan 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

marioevz commented Jan 16, 2025 •

edited by danceratopz

Loading

marioevz commented Jan 22, 2025 •

edited

Loading