eth: add getStorageValues method#756
Merged
Merged
Conversation
Contributor
Author
|
Tests are failing because the latest release of geth doesn't have this method. It means we have to wait until the implementation is released for a green CI. |
s1na
added a commit
to ethereum/go-ethereum
that referenced
this pull request
Feb 23, 2026
Implements the new eth_getStorageValues method. It returns storage values for a list of contracts. Spec: ethereum/execution-apis#756 --------- Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
Contributor
|
@s1na - I think tests can be generated now and merged since geth v1.17.1 is released, do you wanna do that? |
4 tasks
Contributor
Author
|
Should be good to go! |
MysticRyuujin
approved these changes
Mar 5, 2026
4 tasks
MysticRyuujin
added a commit
to MysticRyuujin/nethermind
that referenced
this pull request
Mar 23, 2026
Implements eth_getStorageValues per ethereum/execution-apis#756. Returns storage values for multiple slots across multiple accounts in a single request, reducing round-trip overhead for local simulations. - Max 1024 total slots per request (-32602 on exceed) - Empty request returns -32602 error - Missing accounts/slots return 32 zero bytes - Add ReadAsPropertyName to AddressConverter to support Dictionary<Address, ...> deserialization
3 tasks
14 tasks
Contributor
Author
|
Anything blocking this? |
Contributor
|
Not that I know of |
4 tasks
|
Is this mainly to facilitate batching for RPCs that don't allow regular batch jsonrpc? Is there an advantage to doing it this way instead of regular batching? |
Contributor
Author
|
See here for some of the motivation: #752 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #752