Conversation
da9df27 to
6a785aa
Compare
djrtwo
left a comment
There was a problem hiding this comment.
looks reasonable. My main comment is to consider where this should live and how it be surfaced in the specs.
We also probably need a "meta" section mapping forks to a set of methods. That is, Bellatrix uses all V1, whereas Capella uses a mix.
I would definitely refrain from merging until the Merge dust is fully settled.
great work!
lightclient
left a comment
There was a problem hiding this comment.
Looks good in general to me.
Good point. If kept in the same file it could become a mess after a few forks that are affecting Engine API. Probably it worth having a file per fork as we used to have in consensus specs. In this case we may want to rename |
6a785aa to
fa90a90
Compare
lightclient
left a comment
There was a problem hiding this comment.
Added a note about how to deal with null vs. [] values for withdrawals field.
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
Co-authored-by: terencechain <terence@prysmaticlabs.com>
This PR partially implements [EIP-4895](https://eips.ethereum.org/EIPS/eip-4895): Beacon chain push withdrawals as operations. The new Engine API methods (ethereum/execution-apis#195) are implemented. _Body downloader and saving withdrawals into DB are not implemented yet!_
Adds support for withdrawals.
Part of the validator withdrawals feature tracking here: https://notes.ethereum.org/@ralexstokes/Skp1mPSb9