Add QoS for transition config endpoint#189
Conversation
terencechain
left a comment
There was a problem hiding this comment.
👍🏼
Should we explicitly specify that polling is only required between the Bellatrix fork and the terminal pow block?
mkalinin
left a comment
There was a problem hiding this comment.
In general this looks good to me, and it should also be a good way for users to know that their EL part of the node is ready for transition.
cc'ing @ryanschneider to get input from infra providers' perspective
|
Yup sounds good to me!
…On Mon, Feb 28, 2022 at 11:01 PM Mikhail Kalinin ***@***.***> wrote:
***@***.**** approved this pull request.
In general this looks good to me, and it should also be a good way for
users to know that their EL part of the node is ready for transition.
cc'ing @ryanschneider <https://github.com/ryanschneider> to get input
from infra providers' perspective
—
Reply to this email directly, view it on GitHub
<#189 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAANCEERGORHY2WK6N7MHCDU5W6EXANCNFSM5PSN6EYA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
looks good to me I think the plan @terencechain is to remove this functionality in a subsequent upgrade if it is not of clear value anymore. I'm okay with putting a restriction on it being only until the transition occurs but am okay either way |
I'm okay either way. Prysm doesn't have a restriction. We plan to remove the functionality at some release post-transition, so that means we'll have to coordinate on the timing with all the execution layer client teams |
## Issue Addressed There has been an [`engine_exchangetransitionconfigurationv1`](https://github.com/ethereum/execution-apis/blob/main/src/engine/specification.md#engine_exchangetransitionconfigurationv1) method added to the execution API specs. The `engine_exchangetransitionconfigurationv1` will be polled every 60s as per this PR: ethereum/execution-apis#189. If that PR is merged as-is, then we will be matching the spec. If that PR *is not* merged, we are still fully compatible with the spec, but just doing more than we are required. ## Additional Info - [x] ~~Blocked on #2837~~ - [x] Add method to EE integration tests
This follows from a Discord conversation about using the
engine_exchangeTransitionConfigurationV1endpoint as a "ping" to allow an EL to be aware when it's CL is offline. (cc @djrtwo @mkalinin)I imagine this to be particularly helpful in the space between:
During this period all ELs must be paired with a CL, but there's presently no way for them to know that the CL is connected and live.