precompiles: Fallback to single mul in BLS MSM#1046
Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1046 +/- ##
=======================================
Coverage 94.21% 94.21%
=======================================
Files 153 153
Lines 15934 15940 +6
=======================================
+ Hits 15012 15018 +6
Misses 922 922
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
added a commit
that referenced
this pull request
Oct 9, 2024
It may be intentional to do `&v[0]` instead of `v.data()` as a way of saying "give me the address of the 0th element" instead of "give me the address of the array of elements". An example: #1046.
chfast
added a commit
that referenced
this pull request
Oct 9, 2024
It may be intentional to do `&v[0]` instead of `v.data()` as a way of saying "give me the address of the 0th element" instead of "give me the address of the array of elements". An example: #1046.
If the number of valid and non-zero inputs to BLS MSM is 1 use simpler single point multiplication.
01e0cfb to
cfd11e6
Compare
Member
Author
|
Maybe this is sometimes faster, but not needed for correctness, so let's skip it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the number of valid and non-zero inputs to BLS MSM is 1 use simpler single point multiplication.