Skip to content

clang-tidy: Disable readability-container-data-pointer#1047

Merged
chfast merged 1 commit intomasterfrom
tidy/readability-container-data-pointer
Oct 9, 2024
Merged

clang-tidy: Disable readability-container-data-pointer#1047
chfast merged 1 commit intomasterfrom
tidy/readability-container-data-pointer

Conversation

@chfast
Copy link
Copy Markdown
Member

@chfast chfast commented Oct 9, 2024

It may be intentional to do &v[0] instead of v.data() as a way of saying "give me the address of the 0th element" instead of "give me the address of the array of elements".

An example: #1046.

@chfast
clang-tidy: Disable readability-container-data-pointer
401b579 
It may be intentional to do `&v[0]` instead of `v.data()` as a way of
saying "give me the address of the 0th element" instead of "give me
the address of the array of elements".

An example: #1046.
@chfast chfast requested review from battlmonstr and gumb0 October 9, 2024 13:47
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.21%. Comparing base (8e4a055) to head (401b579).
Report is 8 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1047   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files         153      153           
  Lines       15934    15934           
=======================================
  Hits        15012    15012           
  Misses        922      922
Flag Coverage Δ
eof_execution_spec_tests 17.53% <ø> (ø)
ethereum_tests 27.34% <ø> (ø)
ethereum_tests_silkpre 19.15% <ø> (ø)
execution_spec_tests 20.45% <ø> (ø)
unittests 89.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gumb0
Copy link
Copy Markdown
Member

gumb0 commented Oct 9, 2024

It may be intentional to do &v[0] instead of v.data() as a way of saying "give me the address of the 0th element" instead of "give me the address of the array of elements".

do you mean just for readability, they are always equal in practice? (at least for non-empty containers)

@chfast
Copy link
Copy Markdown
Member Author

chfast commented Oct 9, 2024

It may be intentional to do &v[0] instead of v.data() as a way of saying "give me the address of the 0th element" instead of "give me the address of the array of elements".

do you mean just for readability, they are always equal in practice? (at least for non-empty containers)

Yea, readability.

2 similar comments
@chfast
Copy link
Copy Markdown
Member Author

chfast commented Oct 9, 2024

It may be intentional to do &v[0] instead of v.data() as a way of saying "give me the address of the 0th element" instead of "give me the address of the array of elements".

do you mean just for readability, they are always equal in practice? (at least for non-empty containers)

Yea, readability.

@chfast
Copy link
Copy Markdown
Member Author

chfast commented Oct 9, 2024

It may be intentional to do &v[0] instead of v.data() as a way of saying "give me the address of the 0th element" instead of "give me the address of the array of elements".

do you mean just for readability, they are always equal in practice? (at least for non-empty containers)

Yea, readability.

@chfast chfast merged commit 400f137 into master Oct 9, 2024
@chfast chfast deleted the tidy/readability-container-data-pointer branch October 9, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gumb0 gumb0 gumb0 approved these changes

@battlmonstr battlmonstr Awaiting requested review from battlmonstr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chfast @gumb0