Skip to content

Remove light client infrastructure from phase 0#1329

Merged
djrtwo merged 4 commits into
devfrom
roots-removal
Aug 23, 2019
Merged

Remove light client infrastructure from phase 0#1329
djrtwo merged 4 commits into
devfrom
roots-removal

Conversation

@JustinDrake

@JustinDrake JustinDrake commented Aug 1, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Remove light client infrastructure (active index roots and crosslink committee roots) from phase 0. Alternative infrastructure (namely, persistent committee roots) will be added in phase 1 for light clients (following an improved design). Benefits:

  • Significantly less hashing for the beacon chain (persistent committee roots are relatively rarely updated)
  • Code simplification (40 lines removed)
  • Conceptual cleanup with all light client infrastructure in phase 1

hwwhww
hwwhww approved these changes Aug 6, 2019
View reviewed changes

@hwwhww hwwhww left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍
Note that #1316 needs some updates once this PR has been merged.

@vbuterin

vbuterin commented Aug 6, 2019

Copy link
Copy Markdown
Contributor

Does it? AFAIK the light client PR only uses the added logic in #1323.

@JustinDrake JustinDrake mentioned this pull request Aug 6, 2019
Closed
@vbuterin vbuterin mentioned this pull request Aug 6, 2019
Closed
@hwwhww

hwwhww commented Aug 16, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@vbuterin we will have to copy the definition of CompactCommittee to #1316 if #1329 gets merged first.

class CompactCommittee(Container):
    pubkeys: List[BLSPubkey, MAX_VALIDATORS_PER_COMMITTEE]
    compact_validators: List[uint64, MAX_VALIDATORS_PER_COMMITTEE]

@JustinDrake JustinDrake mentioned this pull request Aug 20, 2019
Closed
@djrtwo djrtwo merged commit c727c47 into dev Aug 23, 2019
@djrtwo djrtwo deleted the roots-removal branch August 23, 2019 19:55
This was referenced Oct 28, 2019
Closed
Merged
@hwwhww hwwhww mentioned this pull request Oct 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hwwhww hwwhww hwwhww approved these changes

+1 more reviewer

@djrtwo djrtwo djrtwo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lightclients

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JustinDrake @vbuterin @hwwhww @djrtwo