Updated light client sync for newer committees#1316
Merged
Conversation
vbuterin
commented
Jul 25, 2019
djrtwo
reviewed
Jul 26, 2019
djrtwo
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Some minor things. Can probably merge relatively soon and clean up/add tests over time.
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
djrtwo
reviewed
Jul 29, 2019
Contributor
|
Heads up: I've started revamping this document and will push a new version tomorrow. Edit: Done :) |
* Lots of cosmetic changes
* A few substantive changes including:
* Use a more conservative threshold of 2/3 (as opposed to 1/2)
* Implement optimisation to use `shard_block_root` (as opposed to `shard_block`)
* Add `fork_version` as part of data to verify aggregate signature
* Various typos/bugs fixed (a few typos/bugs also likely introduced)
djrtwo
reviewed
Aug 14, 2019
Contributor
|
@GregTheGreek brought up the fact that |
djrtwo
approved these changes
Aug 19, 2019
djrtwo
left a comment
Contributor
There was a problem hiding this comment.
anything else to do before merge @vbuterin @JustinDrake ?
Contributor
I'm OK merging :) |
JustinDrake
approved these changes
Aug 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.