EIP 7495: Add ssz generic tests for StableContainer and Profile#3777
Closed
wemeetagain wants to merge 28 commits into
Closed
EIP 7495: Add ssz generic tests for StableContainer and Profile#3777wemeetagain wants to merge 28 commits into
wemeetagain wants to merge 28 commits into
Conversation
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
May 24, 2024
Implement test runner for new consensus-spec tests: - ethereum/consensus-specs#3777
Merged
Contributor
|
Output of |
Member
Just want to note that the |
Contributor
|
This one is superseded by #4529 and can be closed. |
Member
|
Thanks @etan-status. Will close it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EIP-7495 defines two new SSZ types:
StableContainerandProfile.Functionality from this EIP is required in several EIPs currently under consideration:
This PR adds both
StableContainerandProfileto the ssz_generic spec test generators.Output of
make gen_ssz_generic: ssz_generic_7495.tar.gzNotes/TODOs:
StableContainerandProfile. Adding invalid cases may require tweaking some generator helpers for these types.Profileobjects without optional fields. This is sufficient to test all functionality required for EIP-7688 - Forward Compatible Consensus Data Structures, but not sufficient to test all functionality required for EIP-6493 - SSZ Transaction Signature Scheme. More test cases should be added to cover this.