Skip to content

0.01 bit proof of custody [depends on 256 bit custody atoms]#1889

Merged
djrtwo merged 7 commits into
dankrad-custody-256bitfrom
dankrad-custody-0.01bit
Jun 16, 2020
Merged

0.01 bit proof of custody [depends on 256 bit custody atoms]#1889
djrtwo merged 7 commits into
dankrad-custody-256bitfrom
dankrad-custody-0.01bit

Conversation

@dankrad

@dankrad dankrad commented Jun 12, 2020

Copy link
Copy Markdown
Contributor

@dankrad dankrad changed the title Dankrad custody 0.01bit [depends on 256 bit custody atoms] 0.01 bit proof of custody [depends on 256 bit custody atoms] Jun 12, 2020
@dankrad dankrad marked this pull request as ready for review June 13, 2020 14:16
@dankrad dankrad mentioned this pull request Jun 13, 2020
Closed
@dankrad dankrad linked an issue Jun 15, 2020 that may be closed by this pull request
Change to 2^14 epoch custody periods #1888
Closed
@djrtwo djrtwo mentioned this pull request Jun 15, 2020
Merged
16 tasks
djrtwo
djrtwo approved these changes Jun 15, 2020
View reviewed changes

@djrtwo djrtwo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some minor cleanup. In general, this looks awesome.

I'd like to mask get_backing().get_left().merkle_root() into a spec helper with clear indication to implementers what's going on, but we can do that in the larger PR

Comment thread specs/phase1/fork-choice.md
Comment thread specs/phase1/beacon-chain.md
Comment thread tests/core/pyspec/eth2spec/test/helpers/custody.py Outdated
djrtwo
djrtwo approved these changes Jun 16, 2020
View reviewed changes

@djrtwo djrtwo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent!

@djrtwo djrtwo merged commit eec323c into dankrad-custody-256bit Jun 16, 2020
@djrtwo djrtwo deleted the dankrad-custody-0.01bit branch June 16, 2020 13:20
@hwwhww hwwhww mentioned this pull request Jun 16, 2020
Closed
17 tasks
@terencechain terencechain mentioned this pull request Jul 5, 2020
Closed
hwwhww added a commit that referenced this pull request Jul 9, 2020
@hwwhww
The AttesterSlashing tests for phase1 can be enabled now after #1889
60f4bd2
@hwwhww hwwhww mentioned this pull request Jul 9, 2020
Merged
@ljq8896

ljq8896 commented Oct 6, 2022

Copy link
Copy Markdown

Sorry but where is the 0.01bit in the spec? Is this still Implementing? I could only see [Validator](Construct attestation
attestation.data, attestation.aggregation_bits, and attestation.signature are unchanged from Phase 0. But safety/validity in signing the message is premised upon calculation of the "custody bit" [TODO].)?

@ljq8896

ljq8896 commented Oct 6, 2022 •
edited
Loading

Copy link
Copy Markdown

Sorry but where is the 0.01bit in the spec? Is this still Implementing? I could only see [Validator](Construct attestation attestation.data, attestation.aggregation_bits, and attestation.signature are unchanged from Phase 0. But safety/validity in signing the message is premised upon calculation of the "custody bit" [TODO].)?

I try to understand it. There will not be a custody bit in an attestation. Honest Validator just don't sign when it's 1 for 0.1% of the time. So if anyone find a Validator sign the bit calculated 1, the validator can be slashed.

@dankrad

dankrad commented Oct 6, 2022

Copy link
Copy Markdown
Contributor Author

Hi, this is not a place for a discussion. If you have questions, you can ask them for example on the ethresearch post: https://ethresear.ch/t/a-0-001-bit-proof-of-custody/7409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@djrtwo djrtwo djrtwo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change to 2^14 epoch custody periods

3 participants

@dankrad @ljq8896 @djrtwo