Endpoint for fetching blinded blocks#241
Merged
mpetrunic merged 1 commit intoethereum:masterfrom Sep 23, 2022
Merged
Conversation
rolfyone
previously approved these changes
Sep 13, 2022
Contributor
rolfyone
left a comment
There was a problem hiding this comment.
LGTM. should be easy to implement in teku, I know you were seeking opinions on that too...
This was referenced Sep 13, 2022
9c1db6b to
65eaaf6
Compare
65eaaf6 to
612ec1f
Compare
mpetrunic
reviewed
Sep 23, 2022
Contributor
mpetrunic
left a comment
There was a problem hiding this comment.
Small comment, otherwise looks good!
bors bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Nov 10, 2022
## Issue Addressed ethereum/beacon-APIs#241 ethereum/beacon-APIs#242 ## Proposed Changes Implement two new endpoints for fetching blinded blocks and RANDAO mixes. Co-authored-by: realbigsean <sean@sigmaprime.io>
bors bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Nov 11, 2022
## Issue Addressed ethereum/beacon-APIs#241 ethereum/beacon-APIs#242 ## Proposed Changes Implement two new endpoints for fetching blinded blocks and RANDAO mixes. Co-authored-by: realbigsean <sean@sigmaprime.io>
bors bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Nov 11, 2022
## Issue Addressed ethereum/beacon-APIs#241 ethereum/beacon-APIs#242 ## Proposed Changes Implement two new endpoints for fetching blinded blocks and RANDAO mixes. Co-authored-by: realbigsean <sean@sigmaprime.io>
macladson
pushed a commit
to macladson/lighthouse
that referenced
this pull request
Jan 5, 2023
## Issue Addressed ethereum/beacon-APIs#241 ethereum/beacon-APIs#242 ## Proposed Changes Implement two new endpoints for fetching blinded blocks and RANDAO mixes. Co-authored-by: realbigsean <sean@sigmaprime.io>
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed ethereum/beacon-APIs#241 ethereum/beacon-APIs#242 ## Proposed Changes Implement two new endpoints for fetching blinded blocks and RANDAO mixes. Co-authored-by: realbigsean <sean@sigmaprime.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new endpoint analogous to
/eth/v2/beacon/blocks/{block_id}that serves blinded blocks rather than full blocks. The new endpoint is/eth/v1/beacon/blinded_blocks/{block_id}.We already have other endpoints for creating new blinded blocks and POSTing signed blinded blocks back to the BN, so this PR completes the trilogy.
There are several reasons why such an endpoint is useful and desirable:
block_numberof the head block, without fetching all transactions.