Skip to content
This repository was archived by the owner on Oct 28, 2021. It is now read-only.
This repository was archived by the owner on Oct 28, 2021. It is now read-only.

Fix unreliable network/p2p tests #5544

@halfalicious

Description

@halfalicious

I've seen the following tests fail recently in PRs which didn't touch network or p2p code (e.g. #5541)

  • network/net/evictionWithOldNodeAnswering
  • network/net/packetsWithChangedEndpointSuite/neighbours
  • libp2p/p2pPeer/requirePeer

Logs:

evictionWithOldNodeAnswering

495/563 Test #501: network/net/evictionWithOldNodeAnswering ..............................................................................***Failed    0.41 sec
Running tests using path: "/home/builder/project/test/jsontests"
Running 1 test case...
Test Case "evictionWithOldNodeAnswering": 
/home/builder/project/test/unittests/libp2p/net.cpp(854): fatal error: in "network/net/evictionWithOldNodeAnswering": critical check populated has failed
*** 1 failure is detected (5 failures are expected) in the test module "Master Test Suite"

packetsWithChangedEndpointSuite/neighbours

515/563 Test #510: network/net/packetsWithChangedEndpointSuite/neighbours ................................................................***Failed   10.37 sec
Running tests using path: "/home/builder/project/test/jsontests"
Running 1 test case...
Test Case "neighbours": 
/home/builder/project/libdevcore/concurrent_queue.h(47): fatal error: in "_T dev::concurrent_queue<_T, _QueueT>::pop(const milliseconds&) [with _T = std::vector<unsigned char>; _QueueT = std::queue<std::vector<unsigned char>, std::deque<std::vector<unsigned char>, std::allocator<std::vector<unsigned char> > > >; std::chrono::milliseconds = std::chrono::duration<long int, std::ratio<1l, 1000l> >]": boost::exception_detail::clone_impl<dev::WaitTimeout>: /home/builder/project/libdevcore/concurrent_queue.h(47): Throw in function _T dev::concurrent_queue<_T, _QueueT>::pop(const milliseconds&) [with _T = std::vector<unsigned char>; _QueueT = std::queue<std::vector<unsigned char>, std::deque<std::vector<unsigned char>, std::allocator<std::vector<unsigned char> > > >; std::chrono::milliseconds = std::chrono::duration<long int, std::ratio<1l, 1000l> >]
Dynamic exception type: boost::exception_detail::clone_impl<dev::WaitTimeout>
/home/builder/project/test/unittests/libp2p/net.cpp(1253): last checkpoint: "neighbours" test entry
*** 1 failure is detected (5 failures are expected) in the test module "Master Test Suite"

libp2p/p2pPeer/requirePeer

513/563 Test #518: libp2p/p2pPeer/requirePeer ............................................................................................***Failed    0.35 sec
Running tests using path: "/Users/distiller/project/test/jsontests"
Running 1 test case...
Test Case "requirePeer": 
/Users/distiller/project/test/unittests/libp2p/peer.cpp:283: fatal error: in "libp2p/p2pPeer/requirePeer": critical check host1peerCount == 1 has failed [0 != 1]

*** 1 failure is detected (5 failures are expected) in the test module "Master Test Suite"

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions