This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Fix changelog bug and add entry for PR #5538#5541
Merged
halfalicious merged 2 commits intomasterfrom Apr 3, 2019
Merged
Conversation
chfast
suggested changes
Apr 2, 2019
Member
chfast
left a comment
There was a problem hiding this comment.
Also keep the list grouped by "kind": Added, Changed, Removed, Fixed, ...
| ## [1.6.0] - Unreleased | ||
|
|
||
| - Added: [#5484](https://github.com/ethereum/aleth/pull/5485) aleth-bootnode now by default connects to official Ethereum bootnodes. This can be disabled with `--no-bootstrap` flag. | ||
| - Added: [#5485](https://github.com/ethereum/aleth/pull/5485) aleth-bootnode now by default connects to official Ethereum bootnodes. This can be disabled with `--no-bootstrap` flag. |
Member
There was a problem hiding this comment.
I believe this also should be Changed: as it is not a new feature.
Member
There was a problem hiding this comment.
Why not, this is new code and new flag added
Member
There was a problem hiding this comment.
Can be. It rather feels to me we are changing only how features are enabled / disabled. But I don't care much.
PR 5538 removed the --private option from aleth
Grouped entries by kind and changed "added" to "removed" for PR which removed a command-line argument.
7a81e25 to
4518ae2
Compare
Contributor
Author
|
Rebased to address merge conflict |
Contributor
Author
Did that in the new version (grouped changes in that order: Added, Changed, Removed, Fixed) |
chfast
approved these changes
Apr 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 5538 removed the --private option from aleth