Update EIP-7685: remove requests from block body#8908
Closed
lightclient wants to merge 2 commits intoethereum:masterfrom
Closed
Update EIP-7685: remove requests from block body#8908lightclient wants to merge 2 commits intoethereum:masterfrom
lightclient wants to merge 2 commits intoethereum:masterfrom
Conversation
Collaborator
|
✅ All reviewers have approved. |
25 tasks
Co-authored-by: Mario Vega <marioevz@gmail.com> Co-authored-by: lightclient <lightclient@protonmail.com>
marioevz
reviewed
Sep 26, 2024
| @@ -70,7 +55,7 @@ Extend the header with a new 32 byte value `requests_hash`: | |||
| def compute_requests_hash(list): | |||
| return keccak256(rlp.encode([rlp.encode(req) for req in list])) | |||
Member
There was a problem hiding this comment.
From Mikhail's comment in #591 description:
Use concatenation to compute the resulting list of all requests instead of RLP, i.e. do executionRequests = requests_00 || requests_01 || requests_02 instead of requests = RLP([requests_00, requests_01, requests_02]). And use the executionRequests in Engine API and in requestsHash computation, the latter can be as simple as requestsHash = executionRequests(requests)
It seems like this should also be updated to:
Suggested change
| return keccak256(rlp.encode([rlp.encode(req) for req in list])) | |
| return keccak256(b"".join(list)) |
Or something along the lines.
This was referenced Sep 27, 2024
12 tasks
Member
Author
|
superseded by #8924 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the requests from the block body. This change is motivated by a simplification to the engine api: ethereum/execution-apis#591