You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is important to not allow authorization.nonce == 2**64 - 1, because in this case incrementing authority nonce will result in nonce overflowing 64 bit, which is not allowed since EIP-2681
Alternative to adding this to the transaction validity rules could be additional check during delegation setting, but it is simpler this way (fewer checks) and more aligned with existing transaction types validity. It is checked at authorization list processing now.
but it is simpler this way (fewer checks) and more aligned with existing transaction types validity.
Is this true? I feel like add bounds outside of basic type widths might add more complexity since it isn't natively part of decoding (e.g. value too big for type!).
but it is simpler this way (fewer checks) and more aligned with existing transaction types validity.
Is this true? I feel like add bounds outside of basic type widths might add more complexity since it isn't natively part of decoding (e.g. value too big for type!).
I guess you're right, it's probably the same number of checks, so either extra check at transaction validity, or one at processing authorizations. I don't mind it either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is important to not allow
authorization.nonce == 2**64 - 1, because in this case incrementing authority nonce will result in nonce overflowing 64 bit, which is not allowed since EIP-2681Alternative to adding this to the transaction validity rules could be additional check during delegation setting, but it is simpler this way (fewer checks) and more aligned with existing transaction types validity.It is checked at authorization list processing now.