Update EIP-7251: change request to flat encoding#8857
Merged
eth-bot merged 1 commit intoethereum:masterfrom Sep 26, 2024
Merged
Update EIP-7251: change request to flat encoding#8857eth-bot merged 1 commit intoethereum:masterfrom
eth-bot merged 1 commit intoethereum:masterfrom
Conversation
I am proposing to change the encoding of consolidation requests to be exactly equal to how they are returned by the contract. The extra layer of RLP encoding is not necessary, and by removing it, we can avoid defining the structure of these requests in the execution layer client implementation.
Collaborator
|
✅ All reviewers have approved. |
25 tasks
lightclient
approved these changes
Sep 26, 2024
eth-bot
approved these changes
Sep 26, 2024
Collaborator
eth-bot
left a comment
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
This was referenced Oct 1, 2024
somnergy
added a commit
to erigontech/erigon
that referenced
this pull request
Oct 11, 2024
In summary, does away with a lot of earlier complexities related to parsing and encoding consolidation requests. These are now just byte strings, essentially. Refer to the following - ethereum/EIPs#8857 - https://github.com/ethereum/EIPs/pull/8934/files#diff-01ca405a121a1fc77e03df916c4f331b030c2467a4eb66545a34e98a6e476fd6R541 (Address update) Needs interface update - erigontech/interfaces#237 (Tasks board - #12106)
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am proposing to change the encoding of consolidation requests to be exactly equal to how they are returned by the contract. The extra layer of RLP encoding is not necessary, and by removing it, we can avoid defining the structure of these requests in the execution layer client implementation.