Add EIP: Lockable Extension for ERC-721#7066
Merged
SamWilsn merged 57 commits intoethereum:masterfrom Jun 26, 2023
Merged
Conversation
Collaborator
File
|
added 2 commits
May 25, 2023 10:42
added 3 commits
May 25, 2023 10:49
added 2 commits
May 25, 2023 11:46
update contributor info
streamnft-tech
commented
Jun 18, 2023
| * @dev Lock the tokenId if msg.sender is owner and set locker to _locker | ||
| */ | ||
| function lock(uint256 tokenId, address _locker) external; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Hello @sullof , thanks for the suggestion. I have tried to remove redundancies in ERC7066 and I believe EIP6982 is using couple of more functions to achieve the locking functionality. Effectively ERC7066 has lesser code and optimized gas. Let me know your thoughts
SamWilsn
previously approved these changes
Jun 19, 2023
Contributor
Author
|
eth-bot rerun |
added 2 commits
June 19, 2023 23:59
… into ERC721Lockable
flexibrah
approved these changes
Jun 25, 2023
SamWilsn
approved these changes
Jun 26, 2023
Contributor
|
@eth-bot rerun |
21 tasks
streamnft-tech
pushed a commit
to streamnft-tech/EIPs
that referenced
this pull request
Oct 27, 2023
* erc721lockable init * update discussion * update license * update readme * add eip header * update title * update readme * update readme * update readme * update readme * update eip number * update eip number * update eip number * update eip number * update eip number * update readme * update readme * update readme * update readme * error codes * added interface to specification * lint fixe * transfer with lock/approve * rename * readme update * optimize lock/unlock * readme with new functions * readme update * error codes * discussion link * tokenId * remove redundancy * updates test * updates doc * review fixes * overrides and interface correction * add locker to transferAndLock * remove locker * license * doc update * doc update * doc update * author updates --------- Co-authored-by: piyush.chittara <piyush.chittara@coindcx.com> Co-authored-by: Piyush <piyush@Suris-Macbook.local> Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
RaphaelHardFork
pushed a commit
to RaphaelHardFork/EIPs
that referenced
this pull request
Jan 30, 2024
* erc721lockable init * update discussion * update license * update readme * add eip header * update title * update readme * update readme * update readme * update readme * update eip number * update eip number * update eip number * update eip number * update eip number * update readme * update readme * update readme * update readme * error codes * added interface to specification * lint fixe * transfer with lock/approve * rename * readme update * optimize lock/unlock * readme with new functions * readme update * error codes * discussion link * tokenId * remove redundancy * updates test * updates doc * review fixes * overrides and interface correction * add locker to transferAndLock * remove locker * license * doc update * doc update * doc update * author updates --------- Co-authored-by: piyush.chittara <piyush.chittara@coindcx.com> Co-authored-by: Piyush <piyush@Suris-Macbook.local> Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
GAEAlimited
pushed a commit
to GAEAlimited/EIPs
that referenced
this pull request
Jun 19, 2024
* erc721lockable init * update discussion * update license * update readme * add eip header * update title * update readme * update readme * update readme * update readme * update eip number * update eip number * update eip number * update eip number * update eip number * update readme * update readme * update readme * update readme * error codes * added interface to specification * lint fixe * transfer with lock/approve * rename * readme update * optimize lock/unlock * readme with new functions * readme update * error codes * discussion link * tokenId * remove redundancy * updates test * updates doc * review fixes * overrides and interface correction * add locker to transferAndLock * remove locker * license * doc update * doc update * doc update * author updates --------- Co-authored-by: piyush.chittara <piyush.chittara@coindcx.com> Co-authored-by: Piyush <piyush@Suris-Macbook.local> Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: