Website: Rewrite index with filters by fulldecent · Pull Request #6483 · ethereum/EIPs

fulldecent · 2023-02-09T21:10:59Z

New features:

Clear presentation
Focus on the content
Filters

https://youtu.be/gzZqgACuULQ

eth-bot · 2023-02-09T21:11:36Z

File `_data/statuses.yaml`

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File `_includes/eiptable.html`

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File `_includes/social.html`

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File `_layouts/eip.html`

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File `all.html`

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File `core.html`

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File `erc.html`

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File `index.html`

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File `informational.html`

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File `interface.html`

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File `meta.html`

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File `networking.html`

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File `rss/erc-last-call.xml`

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File `rss/erc.xml`

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File `rss/nonerc-last-call.xml`

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File `rss/nonerc.xml`

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

SamWilsn

I haven't gone over this yet, but I would like to before it's merged.

fulldecent · 2023-02-10T14:48:58Z

Hi @SamWilsn thank you for checking in

Pandapip1

This should be split into two PRs. One to add the RSS feeds, the other to add filters.

fulldecent · 2023-02-13T14:15:50Z

I agree there are two concerns in this PR. Maybe they are related maybe they are not.

Don't anybody have feedback yet on the PR as-is? And either part of it?

Pandapip1 · 2023-02-13T20:18:36Z

Don't anybody have feedback yet on the PR as-is? And either part of it?

As previously mentionned, the RSS feeds should be a separate PR. I like the idea of filters in concept, but I would prefer it to be a separate page, instead of overriding the readme.

Pandapip1

Please fix the CI errors

Pandapip1

+0. I like the filters, but I'd rather it not replace the main index.

fulldecent · 2023-02-27T21:58:25Z

@Pandapip1 Is your branch up-to-date? Can I take your index (the rendered static HTML version) and use that in this PR as the homepage? Then I'll move what is currently the homepage here to all.html.

Maybe that's a way to move this PR forward -- and then on a later day separately discuss the merits of the EIPs homepage just being all content.

Pandapip1 · 2023-02-28T13:01:27Z

@Pandapip1 Is your branch up-to-date? Can I take your index (the rendered static HTML version) and use that in this PR as the homepage? Then I'll move what is currently the homepage here to all.html.

I'm +1 to that.

fulldecent · 2023-02-28T14:35:01Z

May I have the deployed link again please

Pandapip1 · 2023-03-01T04:33:48Z

Just use the one here:

https://github.com/ethereum/EIPs/blob/master/index.html

fulldecent · 2023-03-01T17:22:16Z

@Pandapip1 got it

You asked me to separate out this part #6579 is that ready to merge now?

Pandapip1 · 2023-03-01T21:31:45Z

You asked me to separate out this part #6579 is that ready to merge now?

No. It needs one more review.

SamWilsn · 2023-03-08T14:25:20Z

Will this hurt what little SEO we have?

Pandapip1

Keep the all.html page, since removing it would make the EIPs website significantly harder to index.

fulldecent · 2023-03-08T14:30:18Z

I already committed to restore the index.html here. No need to consider that point in this thread.

However I won't continue on this PR until #6579 merges or somebody tells me "I will support #6483 for merge if you xxxx"

github-actions · 2023-03-13T19:05:10Z

The commit 4693f75 (as a parent of 9c72bac) contains errors.
Please inspect the Run Summary for details.

Pandapip1

Please fix the CI errors.

add page fragments

Pandapip1

If you're going to replace the all.html page with the filter page, then I request that you re-add the category-specific pages.

Also, there is some linking to those pages that would break, which would also be bad for SEO.

Pandapip1

Also, the RSS feeds are still in this PR.

github-actions · 2023-07-24T00:19:55Z

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions · 2023-09-05T00:15:58Z

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

fulldecent requested a review from eth-bot as a code owner February 9, 2023 21:10

github-actions bot added the w-ci Waiting on CI to pass label Feb 9, 2023

SamWilsn requested changes Feb 10, 2023

View reviewed changes

Pandapip1 suggested changes Feb 12, 2023

View reviewed changes

Pandapip1 changed the title ~~Rewrite index with filters~~ Website: Rewrite index with filters Feb 12, 2023

fulldecent mentioned this pull request Feb 13, 2023

Agenda request: PR #6483 ethcatherders/EIPIP#215

Closed

Pandapip1 mentioned this pull request Feb 15, 2023

Website: Hide Stagnant and Withdrawn EIPs #6028

Closed

Pandapip1 mentioned this pull request Feb 22, 2023

Website: Migrate to vitepress #6518

Closed

6 tasks

fulldecent mentioned this pull request Feb 24, 2023

Website: more rss feeds #6579

Merged

Pandapip1 suggested changes Feb 27, 2023

View reviewed changes

eth-bot added the e-consensus Waiting on editor consensus label Feb 27, 2023

github-actions bot removed the w-ci Waiting on CI to pass label Feb 27, 2023

Pandapip1 approved these changes Feb 27, 2023

View reviewed changes

poojaranjan mentioned this pull request Mar 8, 2023

EIPIP Meeting 76 ethcatherders/EIPIP#217

Closed

9 tasks

Pandapip1 suggested changes Mar 8, 2023

View reviewed changes

github-actions bot added c-new Creates a brand new proposal c-update Modifies an existing proposal s-draft This EIP is a Draft labels Mar 13, 2023

move to all.html

4693f75

fulldecent force-pushed the focus-on-eips branch from 9fc7506 to 4693f75 Compare March 13, 2023 18:59

github-actions bot removed c-new Creates a brand new proposal c-update Modifies an existing proposal t-core t-erc t-interface t-process s-draft This EIP is a Draft s-review This EIP is in Review s-final This EIP is Final labels Mar 13, 2023

github-actions bot added the w-ci Waiting on CI to pass label Mar 13, 2023

Kourouta approved these changes Mar 14, 2023

View reviewed changes

Kourouta previously approved these changes Mar 14, 2023

View reviewed changes

Pandapip1 suggested changes Mar 14, 2023

View reviewed changes

Update all.html

7b1e4ef

add page fragments

fulldecent dismissed Kourouta’s stale review via 7b1e4ef March 14, 2023 20:38

github-actions bot removed the w-ci Waiting on CI to pass label Mar 14, 2023

Pandapip1 suggested changes Mar 15, 2023

View reviewed changes

github-actions bot added the w-stale Waiting on activity label Jul 24, 2023

github-actions bot closed this Sep 5, 2023

fulldecent mentioned this pull request Mar 3, 2024

Separate EIPs and ERCs #8284

Closed

16 tasks

fulldecent mentioned this pull request Aug 13, 2024

Add (Last) Updated information to the EIP/ERC page #8282

Open

Mahmoudhpp approved these changes Nov 20, 2024

View reviewed changes

fulldecent mentioned this pull request Nov 21, 2024

Filters ethereum/ERCs#727

Open

Beautifulme8 approved these changes Jul 2, 2025

View reviewed changes

Conversation

fulldecent commented Feb 9, 2023

Uh oh!

eth-bot commented Feb 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

File _data/statuses.yaml

File _includes/eiptable.html

File _includes/social.html

File _layouts/eip.html

File all.html

File core.html

File erc.html

File index.html

File informational.html

File interface.html

File meta.html

File networking.html

File rss/erc-last-call.xml

File rss/erc.xml

File rss/nonerc-last-call.xml

File rss/nonerc.xml

Uh oh!

SamWilsn left a comment

Choose a reason for hiding this comment

Uh oh!

fulldecent commented Feb 10, 2023

Uh oh!

Pandapip1 left a comment

Choose a reason for hiding this comment

Uh oh!

fulldecent commented Feb 13, 2023

Uh oh!

Pandapip1 commented Feb 13, 2023

Uh oh!

Pandapip1 left a comment

Choose a reason for hiding this comment

Uh oh!

Pandapip1 left a comment

Choose a reason for hiding this comment

Uh oh!

fulldecent commented Feb 27, 2023

Uh oh!

Pandapip1 commented Feb 28, 2023

Uh oh!

fulldecent commented Feb 28, 2023

Uh oh!

Pandapip1 commented Mar 1, 2023

Uh oh!

fulldecent commented Mar 1, 2023

Uh oh!

Pandapip1 commented Mar 1, 2023

Uh oh!

SamWilsn commented Mar 8, 2023

Uh oh!

Pandapip1 left a comment

Choose a reason for hiding this comment

Uh oh!

fulldecent commented Mar 8, 2023

Uh oh!

github-actions bot commented Mar 13, 2023

Uh oh!

Pandapip1 left a comment

Choose a reason for hiding this comment

Uh oh!

Pandapip1 left a comment

Choose a reason for hiding this comment

Uh oh!

Pandapip1 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 24, 2023

Uh oh!

github-actions bot commented Sep 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

eth-bot commented Feb 9, 2023 •

edited

Loading

File `_data/statuses.yaml`

File `_includes/eiptable.html`

File `_includes/social.html`

File `_layouts/eip.html`

File `all.html`

File `core.html`

File `erc.html`

File `index.html`

File `informational.html`

File `interface.html`

File `meta.html`

File `networking.html`

File `rss/erc-last-call.xml`

File `rss/erc.xml`

File `rss/nonerc-last-call.xml`

File `rss/nonerc.xml`