Skip to content

Pull changes into PR#5983

Merged
Pandapip1 merged 113 commits intoeip-5615-reviewfrom
master
Nov 16, 2022
Merged

Pull changes into PR#5983
Pandapip1 merged 113 commits intoeip-5615-reviewfrom
master

Conversation

@Pandapip1
Copy link
Copy Markdown
Member

"Update branch" button isn't showing for some reason.

Pandapip1 and others added 30 commits October 11, 2022 13:16
* Title setting to 44 characters

* Update eip-4519.md

* Delete Fig5_rev.png

* Delete Figure4.jpg

* Add files via upload

* Update eip-4519.md

* Update eip-4519.md

* Update eip-4519.md

* Update eip-4519.md

* Update eip-4519.md

* Update eip-4519.md

* Update eip-4519.md
* Update eip-5187.md

adding sublease and renewal of the rental so that users can freely transfer the usage rights among each other and extend the lease term.

* Update eip-5187.md
* Title setting to 44 characters

* Update eip-4519.md

* Delete Fig5_rev.png

* Delete Figure4.jpg

* Add files via upload

* Update eip-4519.md

* Update eip-4519.md

* Update eip-4519.md

* Update eip-4519.md

* Update eip-4519.md

* Update eip-4519.md

* Update eip-4519.md

* Delete Figure3.jpg

* Delete Fig5_rev.png

* Delete Figure4.jpg

* Add files via upload

* Delete Figure4.jpg

* Delete Fig5_rev.png

* Add files via upload

* Update eip-4519.md
* Init for method extra data ERC

* Add the major content

* Fix EIPW

* Update status

* Update name

* Fix EIPW

* Update EIPS/eip-5750.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* U

* Update eip-5750.md

* Fix a bit of grammar

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
* Update eip-5187.md

adding sublease and renewal of the rental so that users can freely transfer the usage rights among each other and extend the lease term.

* Update eip-5187.md

* Update eip-5187.md

update identifier for this interface
* init chainidsize EIP pr

* Recover the content from #2294

* EIP formating

* EIP formatting

* Update authost list and add credt

* Move to Review

* Update EIPS/eip-2294.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-2294.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-2294.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update eip-2294.md

* Update eip-2294.md

* Move to Review status

* Update eip-2294.md

* Update eip-2294.md

* Update eip-2294.md

* Update eip-2294.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
* feat: upload eip draft

* fix: update erc number

* feat: upload assets

* fix: update implementation link

* fix: update author info

* feat: upload sample implementation

* fix: add hardhat project config

* fix: revise eip-5727

* fix: change ERC to EIP

* fix: fix links to eip

* fix: update tests

* feat: include interface id; update sample
* NFT authorization - ERC721 extension

* Update and rename eip-4966.md to eip-5585.md

* Update eip-5585.md

* Update eip-5585.md

* Update eip-5585.md

* Update eip-5585.md

* + Change CRLF to LF

* Update EIPS/eip-5585.md

* Update EIPS/eip-5585.md

* Update the author and discussion info

* Update the abstract info

* Delete the information

* Updated the description of this EIP

* Update contract interfaces and EIP-5585 content

* Update based on reviewer's suggestions

* Update some descriptions of this EIP.

* Update the sequences of the contract interfaces

* Update some Typos

* Update the EIP-721 reference Link

* Update based on the reviewer's suggestions

* Update the author info

* Update the author info

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
* CI: Disable certain labels from being stale

* Add manual merge queue to exempt

* Update stale.yml
* EIP2535: Fixed misspelling, tweaked wording

* EIP2535: Updated dependencies

* added space

* EIP2535: Make clear that facets do not have to be reusable

* EIP-2535: additions and improvements
* EIP-2535: small change

* Removed space
* EIP-2535: small change

* Removed space

* EIP-2535: small text change
* Adopt EIP-2771

* Rephrase security considerations

* Move most of the motivation into the rationale

* Update eip-2771.md
* EIP-2535: small change

* Removed space

* EIP-2535: small text change

* Make EIP-2535 Final
* eip-5528 final

* Editor suggestions for EIP-5528

Co-authored-by: Sam Wilson <sam.wilson@mesh.xyz>
* first draft

* rename document

* relative links

* fix EIP Walidator checks

* Apply suggestions from code review

Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

* Remove unecessary requires

Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
* Update eip-template.md

* Update eip-template.md

Co-authored-by: xinbenlv <zzn@zzn.im>

Co-authored-by: xinbenlv <zzn@zzn.im>
* Update README.md

* Update README.md

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
* Update with header

* Update index.html
* Add markdown linter

* Make changes to important files

* Add the thing

* Oof

* Create markdown lint config

* MD003: Force ATX heading style

Co-authored-by: Micah Zoltu <micah@zoltu.net>

* Disable MD006

Co-authored-by: Micah Zoltu <micah@zoltu.net>

* Disable MD036

Co-authored-by: Micah Zoltu <micah@zoltu.net>

* Disable MD043

Co-authored-by: Micah Zoltu <micah@zoltu.net>

* Disable MD039

Co-authored-by: Micah Zoltu <micah@zoltu.net>

* Disable MD007

Co-authored-by: Micah Zoltu <micah@zoltu.net>

* Disable MD027

Co-authored-by: Micah Zoltu <micah@zoltu.net>

* Disable MD037

Co-authored-by: Micah Zoltu <micah@zoltu.net>

* Disable MD014

Co-authored-by: Micah Zoltu <micah@zoltu.net>

* Disable rules by default

Co-authored-by: Micah Zoltu <micah@zoltu.net>

* Disable MD002

Co-authored-by: Micah Zoltu <micah@zoltu.net>

* Disable MD045 (sigh)

Co-authored-by: Micah Zoltu <micah@zoltu.net>

* Apply suggestions from code review

Co-authored-by: Micah Zoltu <micah@zoltu.net>

* Rename .markdownlint.yaml to config/.markdownlint.yaml

* Update ci.yml

* Update config/.markdownlint.yaml

* Re-enable MD022

Co-authored-by: xinbenlv <zzn@zzn.im>

* Rephrase with @xinbenlv's suggestion

Co-authored-by: xinbenlv <zzn@zzn.im>

* Fix markdown again

Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: xinbenlv <zzn@zzn.im>
Co-authored-by: Sam Wilson <sam.wilson@mesh.xyz>
* Shareable NFT eip draft

* EIP numbering to reflect PR number

* added a named author from ATARCA team to build consensus with community

* added a named author from ATARCA team to build consensus with community

* Update EIPS/eip-5023.md

Removed links to external sources according to suggestion.

Co-authored-by: Micah Zoltu <micah@zoltu.net>

* Update EIPS/eip-5023.md

Removed reference to specific ERC-165 implementation.

Co-authored-by: Micah Zoltu <micah@zoltu.net>

* Corrected licence on reference implementation

* Update EIPS/eip-5023.md

Licence should link to licence file in repository.

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5023.md

license file ending corrected

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5023.md

Removed mention of standard as suggested.

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

* Update EIPS/eip-5023.md

Removed mention of standard as suggested.

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

* Update EIPS/eip-5023.md

Grammatical corrections

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

* Renamed interface to follow convention of naming them after EIP number

* Interface functions are implicitly virtual

* Interface ID for IERC5023

* Update EIPS/eip-5023.md

Grammar

Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

* Update EIPS/eip-5023.md

First mention of EIP should have a link to it.

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

* Update EIPS/eip-5023.md

CC0 should have a version number attached to it.

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

* reworking the EIP

* Clarification when Share event is to be emitted

* Update EIPS/eip-5023.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5023.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5023.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5023.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
* Catch up to latest Yellow Paper

* Remove yellow paper ref so that PR can be merged

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
* CI: Pin hashes

* Update ci-rerun-trigger.yml

* Update ci.yml

* Fix CodeSpell
* Add concurrency to ci.yml

* Update auto-label-bot.yml

* Update auto-review-bot.yml

* Update auto-review-trigger.yml
axic and others added 15 commits November 12, 2022 22:53
* Move EIP-5732 to Final

* Wording

* Update requires

* Tighten up grammar

* Fix list formatting

* Tighten security considerations

* Remove random sublist

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
* MOD: eip-5489 to review

* Update EIPS/eip-5489.md

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

* Update EIPS/eip-5489.md

Co-authored-by: xinbenlv <zzn@zzn.im>

* MOD: update introduction

* FIX: lint

* Update EIPS/eip-5489.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5489.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5489.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5489.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* FIX: lint

* DEL: hnft new URI schema

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Co-authored-by: xinbenlv <zzn@zzn.im>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
* chore: set to Review

* fix: lint

* fix: lint
* add Restrict Web3 Provider Object API Injection

* rename to EIP using PR number

* add required EIP 1193

* Update EIPS/eip-5593.md

Co-authored-by: xinbenlv <zzn@zzn.im>

* Update EIPS/eip-5593.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5593.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5593.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5593.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Delete duplicate file

* Create W3 license

* Create Media Capture and Streams.pdf

* That failed

* add optional allow attribute usage for 3P iframes

* update normative restrictions for provider objects

* update test cases with better descriptions

* update link to normative definition of potentially trustworthy origin

* address subdomain test case

* update abstract and motivation for readability and to cite a specific attack

* modify normative statement about private tab usage

* rename EIP to better reference EIP-1193 terminology

* update links to use anchor links

* add @thypon as an author who contributed to intial review and implementation

* edit language to clarify when to inject ETH Provider

* update links to use markdown reference links

* update 3p suborigin iframe case to accurately reflect implementation

* remove optional test cases

* add privacy considerations section

* editorial update about configuring potentially trustworthy origins

* rename 3P to third-party

* change CAIP to EIP text

* remove external links

* add authors note about linking issue

* add links to Github PRs about reference implementations

* editorial updates

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

* address dictator eipw bot's commands

* remove assets folder for EIP-5593

* Move privacy considerations to subheading of security considerations, and move author's note to subheading of abstract

* Oops, fix order

* Fix false positive

* remove reference implementation links

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Co-authored-by: xinbenlv <zzn@zzn.im>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
* set lower target/max

* add throughput rationale
* remove optional

* some language cleanup
* Update eip-4519.md

* Update eip-4519.md
* Create eip-ens-as-holder

* Update eip-ens-as-holder

* Update eip-ens-as-holder

* Update eip-ens-as-holder

* Update eip-ens-as-holder

* Update eip-ens-as-holder

* Update eip-ens-as-holder

* Update EIPS/eip-ens-as-holder

Co-authored-by: Micah Zoltu <micah@zoltu.net>

* Update EIPS/eip-ens-as-holder

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-ens-as-holder

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-ens-as-holder

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-ens-as-holder

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-ens-as-holder

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-ens-as-holder

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-ens-as-holder

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update content

* Update content

* Update content

* Update content

* Add reference implementations and test cases

* Update spacing

* Fix spacing

* Change

* fix format

* Update lint

* Update wording

* Fix typos

Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
* Update README: Update automatic check descriptions

* Apply suggestions from code review

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

* reword

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
* Move to Review

* move to Last Call

* correction to pass bot check

* Update eip-5484.md

Fixed typo: extra space

* completed security considerations

* fixed typos

* Status->Final

* fixed style to pass Markdown linter

* minor fixes to pass markdown linter
@Pandapip1 Pandapip1 requested a review from eth-bot as a code owner November 16, 2022 14:07
@Pandapip1 Pandapip1 merged commit 2432605 into eip-5615-review Nov 16, 2022
@github-actions github-actions bot added c-new Creates a brand new proposal c-update Modifies an existing proposal e-number Waiting on EIP Number assignment s-draft This EIP is a Draft s-final This EIP is Final s-review This EIP is in Review s-stagnant This EIP is Stagnant t-core t-erc t-interface t-meta t-networking t-process labels Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c-new Creates a brand new proposal c-update Modifies an existing proposal e-number Waiting on EIP Number assignment s-draft This EIP is a Draft s-final This EIP is Final s-review This EIP is in Review s-stagnant This EIP is Stagnant t-core t-erc t-interface t-meta t-networking t-process

Projects

None yet

Development

Successfully merging this pull request may close these issues.