Conversation
|
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s): (fail) .github/workflows/ci.yml
(fail) eip-1.md
(fail) README.md
(fail) config/.markdownlint.yaml
(fail) eip-template.md
(fail) last-call.xml
|
|
EIPW has over 18,000 lines of errors 😆 |
|
Oh yea, rationale. This quote describes it well:
I've noticed that such formatting errors sometimes happen. This will catch them. |
|
The commit 27ee9db (as a parent of 868d08a) contains errors. Please inspect the Run Summary for details. |
|
I broke eipw. |
Probably throttling to avoid the rate limiter. We're only allowed 1000 requests per hour. |
|
Yea, the rate limit got 100% used up by codespell and the auto label bot. |
|
The commit ddf5b34 (as a parent of 57346db) contains errors. Please inspect the Run Summary for details. |
|
The commit b41b776 (as a parent of 99eeb5f) contains errors. Please inspect the Run Summary for details. |
|
If there's any way to avoid changing old EIPs, I think we should do it. |
I'll split the PRs. |
|
The commit e19c5a7 (as a parent of 11a8be3) contains errors. Please inspect the Run Summary for details. |
|
The commit fb21558 (as a parent of efc29de) contains errors. Please inspect the Run Summary for details. |
|
I would like to see the linting options limited to only things that are functional and avoid forcing a particular markdown style onto users. For example, If we do choose to integrate this, I wonder if we should move the heading checking that EIPW does to I think we should include a configuration file, and fully populate it (don't rely on any defaults) so it is easy for us to discuss and modify individual rules. |
ad85b15 to
e19c5a7
Compare
|
The commit e19c5a7 (as a parent of aa4cc6b) contains errors. Please inspect the Run Summary for details. |
|
The commit 8f2c35c (as a parent of 60bdf8f) contains errors. Please inspect the Run Summary for details. |
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: xinbenlv <zzn@zzn.im>
Co-authored-by: xinbenlv <zzn@zzn.im>
Will require manual merging, due to modifying 432 files (432 > @eth-bot's limit of 100).
Should not be merged yet. Waiting on DavidAnson/markdownlint-cli2-action#12 to be implemented.