Migrate Travis CI to GitHub Actions#5236
Conversation
|
A critical and unhandled exception has occurred: |
|
Note: fixing the typos in the EIP files is essential for the new CI to function. Otherwise, it will fail all new PRs. |
MicahZoltu
left a comment
There was a problem hiding this comment.
I'm a fan of moving away from Travis CI and over to GitHub Actions. This appears to be a pretty straight port of the Travis CI configuration to GitHub actions.
What was it that changed in codespell though? I don't see it. Just a newer version of codespell?
Codespell used to only run on lines that were changed. However, I can't seem to find a way to do that with GitHub actions, so it's running against the entire repo. |
Also, test out what happens if we remove the exceptions for certain EIPs
lightclient
left a comment
There was a problem hiding this comment.
I guess we're going to test this in prod! :)
* Migrate to Github actions * Remove master branch restriction * Fix first round of bugs * Inline arguments Also, test out what happens if we remove the exceptions for certain EIPs * No idea what happened there
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: