Update EIP-8037: Update parameters and rationale section#11616
Merged
Conversation
Collaborator
|
✅ All reviewers have approved. |
7 tasks
|
The commit 2fda2b5 (as a parent of dcd40a7) contains errors. |
4 tasks
natalejoe
approved these changes
May 8, 2026
7 tasks
This was referenced May 11, 2026
7 tasks
natalejoe
approved these changes
May 12, 2026
CarlBeek
added a commit
to CarlBeek/reth
that referenced
this pull request
May 13, 2026
The current draft of EIP-8037 (PR ethereum/EIPs#11616, "Update numbers and rationale") raises the state-byte parameters: CPSB: 1174 → 1530 STATE_BYTES_PER_STORAGE_SET: 32 → 64 STATE_BYTES_PER_NEW_ACCOUNT: 112 → 120 STATE_BYTES_PER_AUTH_BASE: 23 (unchanged) revm ships the old numbers hardcoded into `with_spec_and_mainnet_gas_params(AMSTERDAM)`, so we now overlay the new values via `GasParams::override_gas` after constructing the cfg env. The same overrides also drive the intrinsic-gas path: `calculate_initial_tx_gas` builds its own GasParams internally with no override hook, so we instantiate `GasParams::new_spec(AMSTERDAM)` ourselves, apply the overrides, and call `initial_tx_gas` directly. Renamed the regular-gas placeholders to match EIP-8038's naming (CREATE_ACCESS / STORAGE_WRITE / ACCOUNT_WRITE / REGULAR_PER_AUTH_BASE_COST) and noted in docstrings that those values are still TBD per the PR. Added ACCOUNT_WRITE (didn't exist before). config_fingerprint now embeds every PR-11616-tracked parameter and tags the spec as `pr-11616`. Any existing block_coverage rows from the old CPSB=1174 era will fingerprint-miss and re-analyse on the next pass. 5 new unit tests lock the constants, the intrinsic-gas math for both create-tx and authorization paths, the runtime gas-table overrides, and the fingerprint string. All 131 lib tests green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@eth-bot rerun |
eth-bot
approved these changes
May 13, 2026
eth-bot
left a comment
Collaborator
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPSBfrom 1174 → 1530STATE_BYTES_PER_STORAGE_SET(32 → 64) andSTATE_BYTES_PER_NEW_ACCOUNT(112 → 120) to include the leaf's key in the on-disk footprint; added a section deriving these byte sizesSTORAGE_WRITE,ACCOUNT_WRITE,CREATE_ACCESS,COLD_ACCOUNT_ACCESS(EIP-8038) andPRECOMPILE_ECRECOVER(EIP-7904); added EIP-7904 torequiresREGULAR_PER_AUTH_BASE_COSTinline and clarified intrinsic regular/state gas accountingquantization_analysis.ipynb; refreshednew_state_added.png