[release-3.6] Keep the --snapshot-count flag#21163
Conversation
We won't generate v2 snapshot files in 3.8 anymore, but etcd is still generating snapshot periodically and will keep this behaviour. During etcd generating snapshot, it does the following two things: 1. generate a snapshot entry in WAL file 2. purge old raft entries So we need to keep the flag --snapshot-count so that users can configure how frequently the snapshot is generated. Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 25 files with indirect coverage changes @@ Coverage Diff @@
## release-3.6 #21163 +/- ##
===============================================
- Coverage 68.96% 68.95% -0.01%
===============================================
Files 420 420
Lines 35731 35731
===============================================
- Hits 24642 24639 -3
+ Misses 9654 9650 -4
- Partials 1435 1442 +7 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
We won't generate v2 snapshot files in 3.8 anymore, but etcd is still generating snapshot periodically and will keep this behaviour. During etcd generating snapshot, it does the following two things:
So we need to keep the flag --snapshot-count so that users can configure how frequently the snapshot is generated.
Link to #21162
cc @fuweid @ivanvc @jberkus @serathius
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.