Skip to content

bump grpc to v1.51.0 from v1.47.0#14834

Merged
serathius merged 1 commit intoetcd-io:mainfrom
fuweid:bump-grpc-1.51
Nov 24, 2022
Merged

bump grpc to v1.51.0 from v1.47.0#14834
serathius merged 1 commit intoetcd-io:mainfrom
fuweid:bump-grpc-1.51

Conversation

@fuweid
Copy link
Copy Markdown
Member

@fuweid fuweid commented Nov 23, 2022

Signed-off-by: Wei Fu <fuweid89@gmail.com>
@serathius
Copy link
Copy Markdown
Member

Please fix unit test

@fuweid
Copy link
Copy Markdown
Member Author

fuweid commented Nov 23, 2022

https://github.com/etcd-io/etcd/actions/runs/3532881659/jobs/5927791293

=== Failed
=== FAIL: transport TestWriteReadTimeoutListener (0.01s)
    timeout_listener_test.go:113: err = EOF, want write i/o timeout error

It maybe a flaky test case.

Let me mark it as draft.

@fuweid fuweid marked this pull request as draft November 23, 2022 14:37
@ptabor
Copy link
Copy Markdown
Contributor

ptabor commented Nov 23, 2022

Seems reproductionable. Failed again:

=== Failed
=== FAIL: transport TestWriteReadTimeoutListener (0.01s)
    timeout_listener_test.go:113: err = EOF, want write i/o timeout error

@fuweid fuweid force-pushed the bump-grpc-1.51 branch 2 times, most recently from 6bb95d9 to cf285ea Compare November 23, 2022 15:58
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 23, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.53%. Comparing base (a47cdc3) to head (cf285ea).
⚠️ Report is 5727 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14834      +/-   ##
==========================================
- Coverage   75.59%   75.53%   -0.06%     
==========================================
  Files         457      457              
  Lines       37357    37421      +64     
==========================================
+ Hits        28239    28267      +28     
- Misses       7343     7376      +33     
- Partials     1775     1778       +3     
Flag Coverage Δ
all 75.53% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ahrtr ahrtr marked this pull request as ready for review November 23, 2022 23:15
Copy link
Copy Markdown
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

Thanks for identifying the root cause of #14487

@serathius serathius merged commit f18ac02 into etcd-io:main Nov 24, 2022
@fuweid
Copy link
Copy Markdown
Member Author

fuweid commented Nov 24, 2022

Still working on the failed test case. It is weird. I can't reproduce it in my local. I was thinking that the connection is closed. Let me file issue to track this.

@fuweid fuweid deleted the bump-grpc-1.51 branch November 24, 2022 09:16
@serathius
Copy link
Copy Markdown
Member

Due to different environment GitHub actions CI frequently flakes on issues that are hard to reproduce locally. I suspect this is due to limited resources, especially CPU. I think you could try to emulate it locally.

@fuweid
Copy link
Copy Markdown
Member Author

fuweid commented Nov 24, 2022

Due to different environment GitHub actions CI frequently flakes on issues that are hard to reproduce locally. I suspect this is due to limited resources, especially CPU. I think you could try to emulate it locally.

Yeah. For sure. I am trying to run it limited-resource vm.

chaochn47 added a commit to chaochn47/etcd that referenced this pull request Oct 17, 2023
backport etcd-io#14834 and etcd-io#16324

Signed-off-by: Chao Chen <chaochn@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[Test] TestLeasingReconnectNonOwnerGet timeout

5 participants