clientv3: fix init client error#14368
Merged
ahrtr merged 1 commit intoetcd-io:mainfrom Nov 6, 2022
Merged
Conversation
Member
|
Two comments:
|
Contributor
Author
|
I have modified and added unit tests. |
Contributor
|
@happlins you need to combine four commits into one |
Contributor
Author
|
sorry,I have revised it. |
ptabor
suggested changes
Aug 29, 2022
Member
|
The minimum version supported should be Please also consider to enhance the unit test to cover more scenarios,such as,
|
Member
|
any update on this? |
Contributor
Author
|
I'm sorry. I've been too busy recently. I've modified the minimum version and added unit test |
ahrtr
reviewed
Oct 13, 2022
ahrtr
reviewed
Oct 13, 2022
ab68bfe to
d3eea7c
Compare
ahrtr
reviewed
Oct 13, 2022
Signed-off-by: happlins <happlins@foxmail.com>
ahrtr
approved these changes
Oct 13, 2022
Member
|
Since there is no response from other maintainers and it's a safe change to me, so let me merge this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix clientv3 init client error
close #14323
Signed-off-by: happlins happlins@foxmail.com
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.