clientv3: PS: Replace balancer with upstream grpc solution#12706
Merged
ptabor merged 1 commit intoetcd-io:masterfrom Feb 23, 2021
Merged
clientv3: PS: Replace balancer with upstream grpc solution#12706ptabor merged 1 commit intoetcd-io:masterfrom
ptabor merged 1 commit intoetcd-io:masterfrom
Conversation
7901bfc to
43a39ec
Compare
Contributor
Author
|
The PR passsed all the tests (so fixing the grpcproxy broken tests). |
Contributor
Author
|
@gyuho - it's a follow up to your comments from #12671 (review), and also is fixing a broken test in grpcproxy test. Please take a look. Thank you. |
gyuho
reviewed
Feb 22, 2021
gyuho
reviewed
Feb 22, 2021
gyuho
reviewed
Feb 22, 2021
gyuho
reviewed
Feb 22, 2021
gyuho
reviewed
Feb 22, 2021
gyuho
reviewed
Feb 22, 2021
Addresses comments from: etcd-io#12671 (review)
Contributor
Author
|
@gyuho - Thank you for your comments. All addressed. Merging to fix the broken grpcproxy test, but pls. let me know if there is anything more I should fix in follow-up PR. |
Contributor
|
@ptabor Awesome. Thanks! |
chaochn47
added a commit
to chaochn47/etcd
that referenced
this pull request
Oct 26, 2023
…ream grpc solution Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
added a commit
to chaochn47/etcd
that referenced
this pull request
Oct 26, 2023
…ream grpc solution Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
added a commit
to chaochn47/etcd
that referenced
this pull request
Oct 27, 2023
…ream grpc solution Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
added a commit
to chaochn47/etcd
that referenced
this pull request
Oct 27, 2023
…ream grpc solution Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
added a commit
to chaochn47/etcd
that referenced
this pull request
Oct 27, 2023
…ream grpc solution Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
added a commit
to chaochn47/etcd
that referenced
this pull request
Oct 30, 2023
…ream grpc solution Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
added a commit
to chaochn47/etcd
that referenced
this pull request
Oct 30, 2023
…ream grpc solution Signed-off-by: Chao Chen <chaochn@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses comments from: #12671 (review)