clientv3: Replace balancer with upstream grpc solution#12671
Merged
ptabor merged 1 commit intoetcd-io:masterfrom Feb 17, 2021
Merged
clientv3: Replace balancer with upstream grpc solution#12671ptabor merged 1 commit intoetcd-io:masterfrom
ptabor merged 1 commit intoetcd-io:masterfrom
Conversation
f6e5e5d to
69cf181
Compare
…_robin LB This commit significantly reduces volume of custom code in etcd client v3, while preserving full existing functionality.
69cf181 to
0b75fed
Compare
Contributor
Author
Contributor
|
LGTM |
Contributor
|
@jingyih any thoughts? |
gyuho
reviewed
Feb 19, 2021
| opts = append(opts, grpc.WithInsecure()) | ||
| } | ||
| opts = append(opts, grpc.WithContextDialer(dialer)) | ||
| grpc.WithDisableRetry() |
Contributor
There was a problem hiding this comment.
Can we add a comment on this? So, now gRPC enables retry by default?
There was a problem hiding this comment.
So, now gRPC enables retry by default?
I don't think so.
// Retry is set if retry is explicitly enabled via "GRPC_GO_RETRY=on".
Retry = strings.EqualFold(os.Getenv(retryStr), "on")
Contributor
Author
There was a problem hiding this comment.
I removed this in follow up PR:
4a1c245#diff-2bbaa3c83234888775aabf7697076e8035451045c479938e03ebb5c929132679L209
In general we should replace clientv3 retry interceptors with RetryPolicy.
gyuho
reviewed
Feb 19, 2021
gyuho
reviewed
Feb 19, 2021
gyuho
reviewed
Feb 19, 2021
gyuho
reviewed
Feb 19, 2021
gyuho
reviewed
Feb 19, 2021
gyuho
reviewed
Feb 19, 2021
Contributor
gyuho
left a comment
There was a problem hiding this comment.
Thanks for clean migration!
Can we please add more comments and address other comments here?
ptabor
added a commit
to ptabor/etcd
that referenced
this pull request
Feb 21, 2021
Addresses comments from: etcd-io#12671 (review)
ptabor
added a commit
to ptabor/etcd
that referenced
this pull request
Feb 22, 2021
Addresses comments from: etcd-io#12671 (review)
ptabor
added a commit
to ptabor/etcd
that referenced
this pull request
Feb 22, 2021
Addresses comments from: etcd-io#12671 (review)
ptabor
added a commit
to ptabor/etcd
that referenced
this pull request
Feb 22, 2021
Addresses comments from: etcd-io#12671 (review)
ptabor
added a commit
to ptabor/etcd
that referenced
this pull request
Feb 22, 2021
Addresses comments from: etcd-io#12671 (review)
ptabor
added a commit
to ptabor/etcd
that referenced
this pull request
Feb 22, 2021
Addresses comments from: etcd-io#12671 (review)
ptabor
added a commit
to ptabor/etcd
that referenced
this pull request
Feb 23, 2021
Addresses comments from: etcd-io#12671 (review)
ptabor
added a commit
to ptabor/etcd
that referenced
this pull request
Feb 23, 2021
Addresses comments from: etcd-io#12671 (review)
Contributor
chaochn47
added a commit
to chaochn47/etcd
that referenced
this pull request
Oct 26, 2023
… grpc solution Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
added a commit
to chaochn47/etcd
that referenced
this pull request
Oct 27, 2023
… grpc solution Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
added a commit
to chaochn47/etcd
that referenced
this pull request
Oct 27, 2023
… grpc solution Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
added a commit
to chaochn47/etcd
that referenced
this pull request
Oct 30, 2023
… grpc solution Signed-off-by: Chao Chen <chaochn@amazon.com>
ahrtr
added a commit
that referenced
this pull request
Oct 31, 2023
[3.4] Backport #12671 clientv3: Replace balancer with upstream grpc solution
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace custom balancer logic in clientv3 with grpc infrastructure:
This commit significantly reduces volume of custom code
in etcd client v3, while preserving full existing functionality.