clientv3: simplify grpc dialer usage.#11574
Merged
gyuho merged 1 commit intoetcd-io:masterfrom Feb 3, 2020
Merged
Conversation
…after bumping grpc to 1.26.0.
Codecov Report
@@ Coverage Diff @@
## master #11574 +/- ##
=========================================
- Coverage 64.57% 63.78% -0.8%
=========================================
Files 403 403
Lines 38097 38074 -23
=========================================
- Hits 24600 24284 -316
- Misses 11851 12130 +279
- Partials 1646 1660 +14
Continue to review full report at Codecov.
|
Contributor
|
There are a few exposed public method removed. Will this affect client API backward compatibility? |
Contributor
Author
Most of them are the workaround from #11184. We can safely remove them after bumping into latest gRPC. |
Contributor
|
lgtm, can we highlight this fix in CHANGELOG 3.5? thx |
Contributor
Author
Sure. Will do after merged. |
YoyinZyc
added a commit
to YoyinZyc/etcd
that referenced
this pull request
Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #11519
verified by tests under tests/docker-dns, tests/dorker-dns-srv, tests/docker-static-ip
@jpbetz @gyuho