Add version, tag and branch checks to release script#11247
Merged
gyuho merged 1 commit intoetcd-io:masterfrom Oct 14, 2019
Merged
Add version, tag and branch checks to release script#11247gyuho merged 1 commit intoetcd-io:masterfrom
gyuho merged 1 commit intoetcd-io:masterfrom
Conversation
Contributor
Author
|
@YoyinZyc would you do a review pass on this as well? |
YoyinZyc
reviewed
Oct 13, 2019
Contributor
YoyinZyc
left a comment
There was a problem hiding this comment.
Overall looks good. Thanks Joe!
| for IMAGE in "quay.io/coreos/etcd:${RELEASE_VERSION}" "gcr.io/etcd-development/etcd:${RELEASE_VERSION}"; do | ||
| local image_version=$(docker run --rm "${IMAGE}" etcd --version | grep "etcd Version" | awk -F: '{print $2}' | tr -d '[:space:]') | ||
| if [ "${image_version}" != "${VERSION}" ]; then | ||
| echo "Check failed: etcd --version output for ${IMAGE} is incorrect: ${image_version}" |
Contributor
There was a problem hiding this comment.
After finding out wrong image, can we remove it right away?
Contributor
Author
There was a problem hiding this comment.
I’d rather not. There are the production release builds. Deleting from them automatically comes with significant risk. If the script reports that they have the wrong version, I’d like a human to intervene and sort out what happened.
Contributor
|
LGTM, Thanks. |
Contributor
|
@YoyinZyc Can you help backport next week? Thx. |
This was referenced Oct 14, 2019
gyuho
added a commit
that referenced
this pull request
Oct 18, 2019
…47-origin-release-3.3 Automated cherry pick of #11247
gyuho
added a commit
that referenced
this pull request
Oct 18, 2019
…47-origin-release-3.4 Automated cherry pick of #11247
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve checks in release script to prevent mistakes like the one I made in the etcd 3.3.16 release (#11241)
etcd --versionand check that it reports the correct version.etcd --versionand check that it reports the correct versionFixes #11241