Skip to content

[combination] Fix 'coeffecient' typo with backward-compatible deprecation#14004

Merged
swoboda1337 merged 1 commit intoesphome:devfrom
swoboda1337:fix-coeffecient-typo
Feb 15, 2026
Merged

[combination] Fix 'coeffecient' typo with backward-compatible deprecation#14004
swoboda1337 merged 1 commit intoesphome:devfrom
swoboda1337:fix-coeffecient-typo

Conversation

@swoboda1337
Copy link
Member

@swoboda1337 swoboda1337 commented Feb 15, 2026 •
edited
Loading

What does this implement/fix?

Fix the typo coeffecient (missing 'i') in the combination sensor's linear type config key. The correct spelling coefficient is now accepted, while the old coeffecient spelling continues to work with a deprecation warning. Also fixes the typo in a C++ comment.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Developer breaking change (an API change that could break external components)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

Pull request in esphome-docs with documentation (if applicable):

Test Environment

  • ESP32 IDF
  • ESP8266
  • RP2040

Example entry for config.yaml:

# New correct spelling
sensor:
  - platform: combination
    type: linear
    name: "Balance Power"
    sources:
      - source: total_power
        coefficient: 1.0
      - source: circuit_1_power
        coefficient: -1.0

# Old spelling still works (with deprecation warning, will be removed in 2026.12.0)
sensor:
  - platform: combination
    type: linear
    name: "Balance Power"
    sources:
      - source: total_power
        coeffecient: 1.0

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@swoboda1337 @claude
[combination] Fix 'coeffecient' typo, add backward-compatible 'coeffi…
3a2082f 
…cient' key

The combination sensor component had a typo in the config key 'coeffecient'
(missing 'i'). This adds the correct 'coefficient' spelling while keeping
backward compatibility with the old spelling via a deprecation warning.

Closes esphome#14003

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2026

👋 Hi there! This PR modifies 2 file(s) with codeowners.

@Cat-Ion, @kahrendt - As codeowner(s) of the affected files, your review would be appreciated! 🙏

Note: Automatic review request may have failed, but you're still welcome to review.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2026

To use the changes from this PR as an external component, add the following to your ESPHome configuration YAML file:

external_components:
  - source: github://pr#14004
    components: [combination]
    refresh: 1h

(Added by the PR bot)

@swoboda1337 swoboda1337 mentioned this pull request Feb 15, 2026
Merged
3 tasks
@swoboda1337 swoboda1337 added this to the 2026.2.0b3 milestone Feb 15, 2026
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.08%. Comparing base (38404b2) to head (3a2082f).

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev   #14004   +/-   ##
=======================================
  Coverage   74.08%   74.08%           
=======================================
  Files          55       55           
  Lines       11588    11588           
  Branches     1577     1577           
=======================================
  Hits         8585     8585           
  Misses       2600     2600           
  Partials      403      403

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2026

Memory Impact Analysis

Components: combination
Platform: esp8266-ard

Metric Target Branch This PR Change
RAM 28,696 bytes 28,696 bytes ➡️ +0 bytes (0.00%)
Flash 288,031 bytes 288,031 bytes ➡️ +0 bytes (0.00%)

Note: This analysis measures static RAM and Flash usage only (compile-time allocation).
Dynamic memory (heap) cannot be measured automatically.
⚠️ You must test this PR on a real device to measure free heap and ensure no runtime memory issues.

This analysis runs automatically when components change. Memory usage is measured from a representative test configuration.

@swoboda1337
Copy link
Member Author

swoboda1337 commented Feb 15, 2026

Thanks

@swoboda1337 swoboda1337 merged commit f48c8a6 into esphome:dev Feb 15, 2026
40 checks passed
jesserockz pushed a commit that referenced this pull request Feb 17, 2026
@swoboda1337 @claude @jesserockz
[combination] Fix 'coeffecient' typo with backward-compatible depreca…
f6362aa 
…tion (#14004)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
@jesserockz jesserockz mentioned this pull request Feb 17, 2026
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bdraco bdraco bdraco approved these changes

@kahrendt kahrendt Awaiting requested review from kahrendt kahrendt is a code owner

Assignees

No one assigned

Labels

bugfix cherry-picked component: combination has-tests

Projects

None yet

Milestone

2026.2.0b3

Development

Successfully merging this pull request may close these issues.

Typo: coeffecient should be coefficient

4 participants

@swoboda1337 @codecov-commenter @bdraco @jesserockz